Merged
Conversation
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
DinneK
requested review from
IsaacMilarky,
decause-gov,
natalialuzuriaga and
sachin-panayil
natalialuzuriaga
approved these changes
Mar 2, 2026
natalialuzuriaga
left a comment
natalialuzuriaga
left a comment
There was a problem hiding this comment.
Just a question double checking a variable but otherwise LGTM!
app/site/_data/site.js
Outdated
| const baseurl = isProduction ? "/metrics" : "" | ||
|
|
||
| // For modification between public and private repos | ||
| const githubBaseUrl = isProduction ? "https://github.cms.gov" : "https://github.com" |
There was a problem hiding this comment.
Just wanted to check, is the isProduction variable the right flag to determine the githubBaseUrl?
Collaborator
Author
There was a problem hiding this comment.
Ooh, this is a really good catch. This solves for production, but not for development. I think the cleanest solution is adding an environmental variable and doing the same in the private metrics repo. I'll add here and then to metrics_internal.
decause-gov
approved these changes
Mar 3, 2026
decause-gov
left a comment
decause-gov
left a comment
There was a problem hiding this comment.
Once Nat's question is addressed, LGTM +1 🚢
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+11
to
+12
| executablePath: "/usr/bin/google-chrome" | ||
| } |
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| executablePath: "/usr/bin/google-chrome" | |
| } | |
| executablePath: "/usr/bin/google-chrome", | |
| }, |
Comment on lines
+14
to
+17
| urls: [ | ||
| "http://localhost:8080" | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| urls: [ | |
| "http://localhost:8080" | |
| ] | |
| } | |
| urls: ["http://localhost:8080"], | |
| } | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A path issue existed in the issues/new urls and extra "/" was being created.
Solution
href="https://{{ site.baseurl }}/{{ org }}/metrics/issues/new"inbanner.liquidtohref="{{ site.githubBaseUrl}}/{{ org }}/metrics/issues/new"this ensure the url behaves the same in both private and public CMS repos.githubBaseUrlto site.jsResult
Path issue fixed.
Next steps