Enforce non-repeatable fields in submission forms

[Wout-atmire]

References

• Fixes Metadata import from external sources: Import allows multiple values for fields defined as non-repeatable in submission forms #10560
• Angular PR Enforce non-repeatable fields in submission forms dspace-angular#4274

Description

Updated the Metadata validation to add an error when a non-repeatable visible input has multiple values.
To prevent imports from submitting items that have multiple values for non-repeatable input fields.

Instructions for Reviewers

List of changes in this PR:

• Updated MetadataValidation#validate to add error (error.validation.not.repeatable) when a non-repeatable visible input has multiple values.

How to test:

• Make dc.contributor.author non-repeatable in the traditionalpageone form (dspace/config/submission-forms.xml)
• Login as a submitter
• Navigate to /import-external
• Search for 38940749 with Pubmed => Import Comparing Gold-Standard Sanger Sequencing with Two Next-Generation Sequencing Platforms of HIV-1 Single Genome Amplicons.
• You should see multiple Authors even though the field isn't repeatable.
• Upload a file and accept the license and click "Deposit"
  • This should fail.
  • In the POST server/api/submission/workspaceitems reques, verify that an error is returned:

  "message" : "error.validation.not.repeatable",
  "paths" : [ "/sections/traditionalpageone/dc.contributor.author" ]
  

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
• My PR passes Checkstyle validation based on the Code Style Guide.
• My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
• My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
• If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[kshepherd]

The scope checking here

if ((!input.isRepeatable() && mdv.size() > 1) && input.isVisible(DCInput.SUBMISSION_SCOPE)

does mean that it wouldn't validate during workflow scope, but.. that applies to other checks like "is required" as well, so I was going to ask if we could extend this check but now I think that might be better as a separate PR, I'll open something later.

[github-actions]

Hi @Wout-atmire,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[tdonohue]

This PR overlaps with the DSpace-CRIS feature being merged in #11964 / DSpace/dspace-angular#5145 as noted in DSpace/dspace-angular#4274 (comment).

Therefore, I'm going to close this PR as this fix will be coming in during the DSpace-CRIS merger. Thanks @Wout-atmire for your contributions to DSpace. If we find this fix has not been fully achieved during the DSpace-CRIS merger, we can always reopen/revisit this PR at a later date.