Fixed headings by their rank #3225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Heading levels on a page should be applied structurally and hierarchically, without skipping levels.
Screen readers and other assistive technologies rely on the correct use of HTML elements to navigate and interpret the content. Misusing heading levels can make it harder for users with visual impairments to understand the structure and flow of a page.
Instructions for Reviewers
To identify inappropriate heading size is used a browser extensions as tool for assistance:
https://wave.webaim.org/extension/ - detects when there are missing headers or skipped levels of heading.
This way, adjusted the heading levels indicated as warnings by the web tool extension, in order to eliminate missing headers or skipped levels of heading.
In some cases, such as for instance, title of a modal that is located inside a

modal-header, we can use a<div>element with anh4class to apply the styles.This way we reach the visual result and avoid using<h4>tag, which might not be semantically appropriate.Example (Discard submission modal):
Reference: Typography
Include guidance for how to test or review your PR.
Here are a few illustrated examples:
Search-page - Missing first level heading


now:
Quality Assurance Suggestions


now:
Other pages examples are:
MyDspace, Quality Assurance (sources-list),
Quality Assurance (topic-list),
Create Community/Collection,
Discard submission modal,
Select a search scope modal,
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.