More accessible file download link for users who use a screen reader

[Andrea-Guevara]

References

• Fixes [Accessibility] Avoid repetition of identical link text on same page #3083

Description

Adding a more detailed description to the file download link using the “attr.aria-label” attribute.

Instructions for Reviewers

In the anchor of the component “file-download-link.component” the attribute “attr.aria-label” has been added to leave a more detailed description of the functionality of the link for users who make use of a screen reader.

List of changes in this PR:

• The attribute “attr.aria-label” has been added
• The translation key “file-download-link.download” has been created
• The “dsoNameService” service has been used to fetch the bitstream name.
• Finally, the translation key was concatenated with the “dsoNameService” service in the “attr.aria-label” attribute.

To reproduce:

1. Visit an item using a screen reader.
2. See list of Download Links at the right side of each file description.
3. See that the screen reader announces the functionality of the link which is “download” plus the name of the file.

[tdonohue]

@Andrea-Guevara : This PR appears to be failing lint checks in the file-download-link.component.ts. See inline comments at https://github.com/DSpace/dspace-angular/pull/3264/files Please fix those lint errors so that the automated tests are able to run on this PR.

[Andrea-Guevara]

Good morning @tdonohue
thank you very much for your comment :)
done!

[github-actions]

Hi @Andrea-Guevara,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[nwoodward]

Hi @Andrea-Guevara. These changes look good on inspection, but I would like to test them to make sure. Could you fix the merge conflicts? They are in the translation files, so they will be quick. Then I will test the PR right away.

[Andrea-Guevara]

@nwoodward Hello, good afternoon.
Sorry for the delay in replying, I've been away for a few days and couldn't reply before!

I've resolved the conflicts. I had some problems with blank spaces in the same translation key files, but these have also been resolved.

If you have any questions, I'd be happy to help.

[nwoodward]

Thanks @Andrea-Guevara! I tested these changes, and they add the aria-label attribute to the Download file links.

[tdonohue]

👍 Thanks @Andrea-Guevara ! Code looks good to me, and I trust the testing of @nwoodward

[dspace-bot]

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3264-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3264-to-dspace-7_x
git switch --create backport-3264-to-dspace-7_x
git cherry-pick -x c02adead7467f414eefd7849704bf6579f41ef14 405a48378cfa2d598d6cb1ec8ddbec0cf17bb268 e43469f67f0bc91bdd62582cf480c07d07eb4bc4 77ea67c359e238dcd0ef57ca218c94c7a43ecdbd 3c41a4d8e6422e646253dda914cf8620903f76e1 0242fb2d04f733c65a4ca1e58f527f5d9dd00767

[dspace-bot]

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3264-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3264-to-dspace-8_x
git switch --create backport-3264-to-dspace-8_x
git cherry-pick -x c02adead7467f414eefd7849704bf6579f41ef14 405a48378cfa2d598d6cb1ec8ddbec0cf17bb268 e43469f67f0bc91bdd62582cf480c07d07eb4bc4 77ea67c359e238dcd0ef57ca218c94c7a43ecdbd 3c41a4d8e6422e646253dda914cf8620903f76e1 0242fb2d04f733c65a4ca1e58f527f5d9dd00767

[tdonohue]

Manually ported to 8.x in #3762 and 7.x in #3763