Difficult to find users to delete from group in large groups #3286

iam-vir-harshit · 2024-08-31T13:11:17Z

References

Fixes Difficult to find users to delete from group in large groups #2869
Requires Backend PR: Difficult to find users to delete from group in large groups DSpace#9793

Description -

The list of current members on the edit group page is searchable now;
Edit EPerson page allows (admins) to delete person from groups it is a member of without having to go to that
group page.

List of changes in this PR:

For searching the current editing group members (includes frontend and backend task) :-
a) - In the Frontend, we have added a search form;
b) - In the Backend, we have added a search method("findIsMemberOf") that receives current editing group id and query parameter which
searches in the current member's list of the editing group;
For deleting the eperson from groups (includes only frontend task) :-
a) - We have only added an extra column in the edit eperson page for giving remove button;
b) - We are utilizing the same api created for unlinking an eperson from the group in the edit group page;

Steps to reproduce:-

Task 1- Search option in the group edit page (in current epeople members section)

Login as admin user
Go to Access Control option in the side pannel
Then go to Groups section in the Access Control
Then choose a group to edit and enter into the edit group screen
In the current members of EPeople section, now you will get a search option to search a member

Task 2- Remove button in the particular EPeople edit page

Login as admin user
Go to Access Control option in the side pannel
Then go to People section in the Access Control
Then choose a epeople to edit and enter into the edit epeople screen
At the bottom, in the "Member of these groups" section, now you will find remove button corresponding to each group

github-actions · 2024-10-14T21:48:58Z

Hi @iam-vir-harshit,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

iam-vir-harshit · 2024-12-10T10:36:44Z

Rebased with dspace-angular main branch

tdonohue

@iam-vir-harshit : Thanks also for this PR! Apologies for the delay in reviewing this, but we gave this a code review as a team in today's Developer Meeting. Overall, the code looks good, but again we are noticing that automated tests are missing:

The changes to eperson-form.component.ts should all be tested in eperson-form.component.spec.ts
Similarly, the changes to members-list.component.ts should all have automated tests in members-list.component.spec.ts.

Once those automated tests are added, the Codecov warnings on this PR (in the "Files changed" tab) should go away (or mostly go away). We can then work to get this tested and merged quickly. Thanks again!

github-actions · 2025-03-11T19:15:21Z

Hi @iam-vir-harshit,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

tdonohue · 2025-03-12T14:44:11Z

@iam-vir-harshit : Just a friendly reminder, that if you want this PR to be considered for the 9.0 release, we will need to have the feedback above resolved soon (and any merge conflicts resolved). Our 9.0 feature merger deadline is March 28. Anything not approved & merged by that date will unfortunately need to be delayed for the next major release.

github-actions · 2025-05-05T19:32:45Z

Hi @iam-vir-harshit,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

github-actions · 2025-05-16T21:04:11Z

Hi @iam-vir-harshit,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

tdonohue

@iam-vir-harshit and @PitbaranK : We reviewed this as a team in today's DSpace Developers Meeting. I've summarized the code review feedback in the comments below. Let us know once you've addressed these comments, and hopefully we can find someone to quickly re-review or test it.

tdonohue · 2025-07-17T15:09:05Z

src/app/access-control/epeople-registry/eperson-form/eperson-form.component.html


      @if (activeEPerson$ | async) {
-        <h1 class="border-bottom pb-2">{{messagePrefix + '.edit' | translate}}</h1>
+      <h1 class="border-bottom pb-2">{{messagePrefix + '.edit' | translate}}</h1>


All these re-alignment changes should be removed, as it makes the code more difficult to read. It's possible these occurred automatically from your IDE, but please remove any unnecessary changes to code alignment from this file.

tdonohue · 2025-07-17T15:10:20Z

src/app/access-control/epeople-registry/eperson-form/eperson-form.component.html

+                </tr>
+              </thead>
+              <tbody>
+                @for (group of (groups$ | async)?.payload?.page; track group) {


All the changes in this file appear to be code realignment. We don't see where you've added the delete button to this page? Is there code missing?

You should remove all the alignment changes (i.e. undo all current changes to this file), and double check that the delete button has been added into this HTML.

tdonohue · 2025-07-17T15:11:14Z

src/app/access-control/epeople-registry/eperson-form/eperson-form.component.ts

+   * Deletes a given group from the Group list of the eperson currently being edited present in
+   * @param group  group we want to delete as of which the current eperson being edited is member of
+   */
+  deleteGroupFromMember(group: Group) {


This method is only being called in your spec file. I suspect it's supposed to be called by an actual delete button.

tdonohue · 2025-07-17T15:12:26Z

src/app/access-control/group-registry/group-form/members-list/members-list.component.ts

  searchDone: boolean;

+  // Whether or not user has done a EPeople Member search yet
+  searchCurrentMembersDone: boolean;


This variable is never used. We believe it can be removed.

tdonohue · 2025-07-17T15:13:50Z

...w-action/advanced-workflow-action-select-reviewer/reviewers-list/reviewers-list.component.ts


  selectedReviewers: EPerson[] = [];

+  searchCurrentMembersForm: UntypedFormGroup;


Why did you add this form to the reviewers-list.component.ts? It doesn't appear to be used at all? Either it should be used or it should be removed.

tdonohue · 2025-07-17T15:14:39Z

src/assets/i18n/en.json5


+  "admin.access-control.epeople.form.table.remove": "Remove",
+
+  "admin.access-control.epeople.form.table.edit.buttons.removegroup": "Remove member from group \"{{name}}\"",


These two i18n keys are not used at this time. But, I suspect it is because there's code missing from your eperson-form.component.html file.

…arge groups.

PitbaranK · 2025-08-19T07:56:29Z

Hi @tdonohue,
We have incorporated all the feedbacks against code review provided by you. Can you please update on the same?

@MarieVerdonck,
Can you please review the changes against #2869 and let us know will it fulfil the requirements?

github-actions · 2025-08-22T15:11:45Z

Hi @iam-vir-harshit,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

tdonohue · 2025-08-22T15:21:51Z

@iam-vir-harshit : This PR has a merge conflict because it looks like you've updated every *.json5 translation file in this PR. That's usually not the best practice because it will result in this PR having a merge conflict nearly every time someone adds new translations.

Instead, we recommend only updating the en.json5 file when adding new i18n keys. If you wanted to translate those keys immediately you could update them in one or two other *.json5 files. But, we have a process where we "re-sync" all other *.json5 files, so it's not necessary for you to do that re-sync in this PR...as it will make it more difficult for you to keep this PR free of merge conflicts.

… Translation Files Changes except en.json5

iam-vir-harshit · 2025-08-25T06:35:46Z

Reopening this PR with the recommended *.json5 translation file changes rollback except the en.json5 changes.

…g Rollback Changes

- Missing Changes

- Fix Indentation in en.json5

iam-vir-harshit · 2025-08-25T08:09:52Z

@tdonohue,
As we can see, there are test case failures in run tests (18.x) are not related to our changes. Can you please re run the same from your side once?

github-actions · 2025-11-10T20:18:41Z

Hi @iam-vir-harshit,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

github-actions bot assigned iam-vir-harshit Aug 31, 2024

tdonohue mentioned this pull request Sep 3, 2024

Difficult to find users to delete from group in large groups DSpace/DSpace#9793

Open

tdonohue added authorization related to authorization, permissions or groups new feature labels Sep 3, 2024

github-actions bot added the merge conflict label Oct 14, 2024

github-actions bot removed the merge conflict label Nov 16, 2024

iam-vir-harshit closed this Dec 10, 2024

iam-vir-harshit force-pushed the main branch from 7f2d045 to dcea3ba Compare December 10, 2024 10:32

iam-vir-harshit reopened this Dec 10, 2024

tdonohue requested changes Dec 19, 2024

View reviewed changes

github-actions bot added the merge conflict label Mar 11, 2025

tdonohue moved this from 👀 Under Review to ❓ Stalled/On Hold in DSpace 9.0 Release Mar 28, 2025

Difficult to find users to delete from group in large groups

7be5d99

iam-vir-harshit force-pushed the main branch from 4c63490 to 7be5d99 Compare April 1, 2025 06:02

github-actions bot removed the merge conflict label Apr 1, 2025

tdonohue added this to DSpace 10.0 Release Apr 2, 2025

tdonohue removed this from DSpace 9.0 Release Apr 2, 2025

tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Apr 2, 2025

github-actions bot added the merge conflict label May 5, 2025

Merge branch 'main' into main

8f43fa7

github-actions bot removed the merge conflict label May 13, 2025

fixed unit test

b1b9375

github-actions bot added the merge conflict label May 16, 2025

tdonohue moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 10.0 Release May 19, 2025

tdonohue requested a review from MarieVerdonck July 17, 2025 14:58

tdonohue requested changes Jul 17, 2025

View reviewed changes

iam-vir-harshit and others added 3 commits August 18, 2025 12:21

Merge branch 'DSpace:main' into main

ad8abcf

Fix for difficult to find users to delete from group in large groups.

6b352d1

Indentation Fix for difficult to find users to delete from group in l…

49f7e69

…arge groups.

tdonohue self-requested a review August 22, 2025 15:07

github-actions bot added the merge conflict label Aug 22, 2025

iam-vir-harshit closed this Aug 25, 2025

iam-vir-harshit force-pushed the main branch from 49f7e69 to e6f9e8c Compare August 25, 2025 05:58

github-project-automation bot moved this from 👀 Under Review to ✅ Done in DSpace 10.0 Release Aug 25, 2025

iam-vir-harshit added 2 commits August 25, 2025 12:01

Difficult to find users to delete from group in large groups - Remove…

fd69ae3

… Translation Files Changes except en.json5

Merge branch 'main' of https://github.com/iam-vir-harshit/dspace-angular

b554ab7

iam-vir-harshit reopened this Aug 25, 2025

github-actions bot removed the merge conflict label Aug 25, 2025

iam-vir-harshit added 3 commits August 25, 2025 12:30

Difficult to find users to delete from group in large groups - Missin…

b02949d

…g Rollback Changes

Difficult to find users to delete from group in large groups

b907e86

- Missing Changes

Difficult to find users to delete from group in large groups

07f2b80

- Fix Indentation in en.json5

Merge branch 'DSpace:main' into main

611d969

github-actions bot added the merge conflict label Nov 10, 2025

Merge branch 'main' into main

0343eef

github-actions bot removed the merge conflict label Nov 12, 2025

iam-vir-harshit added 2 commits November 12, 2025 17:18

Fix Lint Errors

0807a2b

Fix Lint Errors

fc7cd5f

tdonohue moved this from ✅ Done to 👀 Under Review in DSpace 10.0 Release Nov 13, 2025


		selectedReviewers: EPerson[] = [];

		searchCurrentMembersForm: UntypedFormGroup;


		"admin.access-control.epeople.form.table.remove": "Remove",

		"admin.access-control.epeople.form.table.edit.buttons.removegroup": "Remove member from group \"{{name}}\"",

Difficult to find users to delete from group in large groups #3286

Are you sure you want to change the base?

Difficult to find users to delete from group in large groups #3286

Uh oh!

Conversation

iam-vir-harshit commented Aug 31, 2024 • edited by tdonohue Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References

Description -

Uh oh!

github-actions bot commented Oct 14, 2024

Uh oh!

iam-vir-harshit commented Dec 10, 2024

Uh oh!

tdonohue left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 11, 2025

Uh oh!

tdonohue commented Mar 12, 2025

Uh oh!

github-actions bot commented May 5, 2025

Uh oh!

github-actions bot commented May 16, 2025

Uh oh!

tdonohue left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tdonohue Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

tdonohue Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

tdonohue Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

tdonohue Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

tdonohue Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

tdonohue Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

PitbaranK commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 22, 2025

Uh oh!

tdonohue commented Aug 22, 2025

Uh oh!

iam-vir-harshit commented Aug 25, 2025

Uh oh!

iam-vir-harshit commented Aug 25, 2025

Uh oh!

github-actions bot commented Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iam-vir-harshit commented Aug 31, 2024 •

edited by tdonohue

Loading

tdonohue left a comment •

edited

Loading

PitbaranK commented Aug 19, 2025 •

edited

Loading