Fixes duplicate tree view add button for closed Controlled Vocabularies

[aseyedia]

References

Fixes #3325

Description

The Controlled Vocabulary tree view was displaying two "Add" buttons, one enabled and one disabled, for closed Controlled Vocabularies.

You can read more here.

Instructions for Reviewers

Minor change. I just removed one of the excess buttons and moved the conditional logic to the [disabled] parameter in the button class.

To test it, try opening up a closed Controlled Vocabulary tree view and observing the "Add" button to make sure it's disabled and that there's only one of them.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[aseyedia]

@tdonohue I can port this change if it gets approved, unless I need to port it first, in which case, I will do that.

[tdonohue]

@aseyedia : You do not need to port this PR prior to review. In fact, we have an automated porting process which is triggered if we merge a PR with a port to [branch] label. This automated process usually works well for small PRs (like this one), but will sometimes fail. So, we'd only ask you to port this PR yourself if we find that automated process fails.

[github-actions]

Hi @aseyedia,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[aseyedia]

Finally got around to resolving the commit. Let me know if there are any issues.

[tdonohue]

@aseyedia : This PR now has lint errors:

Linting "dspace-angular"...

/home/runner/work/dspace-angular/dspace-angular/src/app/shared/form/vocabulary-treeview/vocabulary-treeview.component.html
Lint errors found in the listed files.

Error:   18:11  error  Buttons should use the `dsBtnDisabled` directive instead of the `disabled` attribute  dspace-angular-html/no-disabled-attribute-on-button
Error:   18:11  error  Buttons should use the `dsBtnDisabled` directive instead of the `disabled` attribute  dspace-angular-html/no-disabled-attribute-on-button

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

You need to use the (newly added) dsBtnDisabled directive instead of disabled.

[aseyedia]

I feel like someone already fixed this issue:

dspace-angular/src/app/shared/form/vocabulary-treeview/vocabulary-treeview.component.html

Lines 21 to 24 in bf20787

	<button class="btn btn-outline-primary" type="button" (click)="add()" [dsBtnDisabled]="this.vocabularyOptions.closed"
	[attr.aria-label]="'vocabulary-treeview.search.form.add' | translate">
	{{'vocabulary-treeview.search.form.add' | translate}}
	</button>

I'm going to close this PR.