Skip to content

Accessibility in the statistics table #3380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Andrea-Guevara wants to merge 17 commits into from
Closed

Accessibility in the statistics table #3380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
267bbd0
Accessibility in the statistics table - adding a dynamic label to the…
Andrea-Guevara Oct 2, 2024
567dffa
back to the tags that were being used at first
Andrea-Guevara Oct 3, 2024
6e47be7
New attempt -back to the tags that were being used at first
Andrea-Guevara Oct 3, 2024
389d38d
Configuring e2e statistics tests to accept the td tag and adding test…
Andrea-Guevara Oct 22, 2024
cc7b272
Trying to solve the final spaces not allowed error
Andrea-Guevara Oct 23, 2024
8b9d0e6
Trying to solve the final spaces not allowed error
Andrea-Guevara Oct 23, 2024
9efa90f
Checking the collection-statistics.cy.ts test
Andrea-Guevara Oct 23, 2024
941cb99
Back to the data-test statistics-label settings
Andrea-Guevara Oct 23, 2024
8633d77
adjusting the file item-statistics.cy.ts
Andrea-Guevara Oct 23, 2024
6b05354
Merge branch 'main' into AccessibilityInStatisticsTable
Andrea-Guevara Dec 17, 2024
6bb1c50
Removing unauthorized spaces
Dec 17, 2024
796e0fc
Removing unauthorized spaces
Dec 17, 2024
4413fb5
Merge branch 'main' into AccessibilityInStatisticsTable
Andrea-Guevara Dec 19, 2024
cc4deaa
Merge branch 'main' into AccessibilityInStatisticsTable
Andrea-Guevara Jan 30, 2025
0987607
Code refactoring
Jan 30, 2025
6c0a5a9
Removing tests that are no longer needed
Jan 30, 2025
2eb5052
Merge branch 'main' into AccessibilityInStatisticsTable
Andrea-Guevara Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/statistics-page/statistics-table/statistics-table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ <h2 class="m-1">
<tbody>

<tr>
<td></td>
<th scope="col">{{ objectHeaderLabel }}</th>
<th scope="col"
*ngFor="let header of headers"
class="{{header}}-header">
Expand Down
14 changes: 14 additions & 0 deletions src/app/statistics-page/statistics-table/statistics-table.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ export class StatisticsTableComponent implements OnInit {
*/
headers: string[];

/**
* Object header label
*/
objectHeaderLabel: string;

constructor(
protected dsoService: DSpaceObjectDataService,
protected nameService: DSONameService,
Expand All @@ -71,6 +76,7 @@ export class StatisticsTableComponent implements OnInit {
if (this.hasData) {
this.headers = Object.keys(this.report.points[0].values);
}
this.objectHeaderLabel = this.getObjectHeaderLabel(this.report.reportType);
}

/**
Expand All @@ -91,4 +97,12 @@ export class StatisticsTableComponent implements OnInit {
return of(point.label);
}
}

/**
* Defines a dynamic label for the object column
* @param reportType
*/
getObjectHeaderLabel(reportType: string): string {
return this.translateService.instant('statistics.table.header.' + reportType);
}
}
10 changes: 10 additions & 0 deletions src/assets/i18n/en.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6781,4 +6781,14 @@
"live-region.ordering.dropped": "{{ itemName }}, dropped at position {{ index }} of {{ length }}.",

"dynamic-form-array.sortable-list.label": "Sortable list",

"statistics.table.header.TotalVisits": "Object",

"statistics.table.header.TotalVisitsMonth": "Month",

"statistics.table.header.TotalDownloads": "Downloads",

"statistics.table.header.TopCities": "Cities",

"statistics.table.header.topCountries": "Countries",
}
15 changes: 15 additions & 0 deletions src/assets/i18n/es.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10194,4 +10194,19 @@

// "search-facet-option.update.announcement": "The page will be reloaded. Filter {{ filter }} is selected.",
"search-facet-option.update.announcement": "La página será recargada. Filtro {{ filter }} seleccionado.",

// "statistics.table.header.TotalVisits": "Object",
"statistics.table.header.TotalVisits": "Objeto",

// "statistics.table.header.TotalVisitsMonth": "Month",
"statistics.table.header.TotalVisitsMonth": "Mes",

// "statistics.table.header.TotalDownloads": "Downloads",
"statistics.table.header.TotalDownloads": "Descargas",

// "statistics.table.header.TopCities": "Cities",
"statistics.table.header.TopCities": "Ciudades",

// "statistics.table.header.topCountries": "Countries",
"statistics.table.header.topCountries": "Países",
}
15 changes: 15 additions & 0 deletions src/assets/i18n/pt-BR.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10243,4 +10243,19 @@

// "search-facet-option.update.announcement": "The page will be reloaded. Filter {{ filter }} is selected.",
"search-facet-option.update.announcement": "A página será recarregada. O filtro {{ filter }} foi selecionado.",

// "statistics.table.header.TotalVisits": "Object",
"statistics.table.header.TotalVisits": "Objeto",

// "statistics.table.header.TotalVisitsMonth": "Month",
"statistics.table.header.TotalVisitsMonth": "Mês",

// "statistics.table.header.TotalDownloads": "Downloads",
"statistics.table.header.TotalDownloads": "Downloads",

// "statistics.table.header.TopCities": "Cities",
"statistics.table.header.TopCities": "Cidades",

// "statistics.table.header.topCountries": "Countries",
"statistics.table.header.topCountries": "Países",
}
Loading