Improve descriptive labels for show/hide x more buttons for related items (Item/Entity Homepage)#3413
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Jan 24, 2025
Merged
Conversation
…related items lists
tdonohue
approved these changes
Jan 24, 2025
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alisaismailati ! Apologies for the delay, but I just got around to testing this today, and this works perfectly. I've verified it solves the minor accessibility bug.
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Reference description in #1183 / Point 1
Instructions for Reviewers
aria-labelto be provided for simple basic buttons. They have an accessible name, the text itself: ARIA: button role - Accessibility | MDNtext-capitalizerule has been added to ensure that the first letter of each word is capitalized, eliminating the need to update each translation individually.ITChecklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.