[Port dspace-7_x] Fix infinite loading on item pages and optimize menu resolver usage #3716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st and the ResponsePending are not emitted (cherry picked from commit 0f4d71e)
… item bitstream & relationship tabs (cherry picked from commit decacec)
…nuResolver on pages who use the DsoEditMenuComponent (cherry picked from commit 5c9f494)
…heir-response_contribute-7.6' into dspace-7_x # Conflicts: # src/app/core/data/base/base-data.service.spec.ts # src/app/core/data/base/base-data.service.ts # src/app/item-page/edit-item-page/abstract-item-update/abstract-item-update.component.ts
alexandrevryghem
added
bug
high priority
performance / caching
Contributor
|
Thanks @alexandrevryghem. It seems GitHub CI got stuck and the Node.js 18 / 20 jobs never started, so I'm going to close and re-open the pull request to trigger those. |
tdonohue
approved these changes
Dec 18, 2024
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! Finally got back to testing this backport. It looks good and works well.
alexandrevryghem
deleted the
w2p-120109_fix-findByHref-and-findListByHref-skipping-their-response_contribute-7_x
branch
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Oct 29, 2025
[DSC-2560] update envs Approved-by: Giuseppe Digilio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual port of #3677 to
dspace-7_x(theBaseDataServicefixes are actually not required, but at least this way all supported DSpace versions work in the same way).The differences with the
dspace-8_x&mainPRs are:menuresolver is still present on the browse pages. This is because the browse pages are still used to represent the comcol pages ondspace-7_xto render the browse tabs (fixed in Refactored community & collection pages #2722 for DSpace 8.0)dspace-8_x