Remove nested span elements with duplicate content of parent elements #3719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschaszott
changed the title
tdonohue
added
bug
1 APPROVAL
artlowel
approved these changes
Dec 9, 2024
Member
artlowel
left a comment
artlowel
left a comment
There was a problem hiding this comment.
Thanks @saschaszott!
While this works, and can be merged as is, would you mind also removing those text-muted classes inside the tooltips? That would be another a11y improvement
Contributor
|
Successfully created backport PR for |
This was referenced Jan 7, 2025
Merged
Contributor
|
Successfully created backport PR for |
tdonohue
removed
port to dspace-7_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes redundant nested span elements in various template files. These span elements contained identical content with respect to their parent elements.