[Port dspace-7_x] Removed observable function calls from template (part 1) #3721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… between different groups Also fixed edit ePerson not showing the group names
…te-7.6' into dspace-7_x # Conflicts: # src/app/access-control/epeople-registry/epeople-registry.component.html # src/app/access-control/epeople-registry/epeople-registry.component.ts # src/app/access-control/epeople-registry/eperson-form/eperson-form.component.html # src/app/access-control/epeople-registry/eperson-form/eperson-form.component.spec.ts # src/app/access-control/epeople-registry/eperson-form/eperson-form.component.ts # src/app/access-control/group-registry/group-form/group-form.component.html # src/app/access-control/group-registry/group-form/group-form.component.ts # src/app/admin/admin-registries/bitstream-formats/bitstream-formats.component.html # src/app/admin/admin-registries/bitstream-formats/bitstream-formats.component.spec.ts # src/app/admin/admin-registries/metadata-registry/metadata-schema-form/metadata-schema-form.component.ts # src/app/admin/admin-registries/metadata-schema/metadata-schema.component.html # src/app/admin/admin-registries/metadata-schema/metadata-schema.component.ts # src/app/shared/pagination/pagination.component.ts
…he create ePerson page (cherry picked from commit 0cb5b76)
…n the profile page (cherry picked from commit ded0079)
…te-7.6' into w2p-117573_remove-observable-function-calls-from-template_contribute-7_x
alexandrevryghem
added
bug
high priority
performance / caching
12 tasks
tdonohue
approved these changes
Dec 18, 2024
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! Gave this a quick test against the dspace-7_x branch and it looks to work well. Bugs are all fixed in 7.x as well.
alexandrevryghem
deleted the
w2p-117573_remove-observable-function-calls-from-template_contribute-7_x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual port of #3585 & #3720 to
dspace-7_x