Skip to content

Improving the color contrast of home news content#3880

Merged
tdonohue merged 3 commits intoDSpace:mainfrom
Andrea-Guevara:HomeNewsColorContrast
Jan 24, 2025
Merged

Improving the color contrast of home news content#3880
tdonohue merged 3 commits intoDSpace:mainfrom
Andrea-Guevara:HomeNewsColorContrast

Conversation

@Andrea-Guevara
Copy link
Contributor

@Andrea-Guevara Andrea-Guevara commented Jan 22, 2025

References

Description

Improved color contrast of home news content.

Instructions for Reviewers

List of changes in this PR:

  • In the “home-news.component” component, the font weight has been increased,
  • In the style file “_theme_css_variable_overrides.scss” the banner has been darkened a little.

Use an accessibility tool to see if the home news content is more accessible.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug accessibility 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jan 22, 2025
@tdonohue tdonohue added this to the 9.0 milestone Jan 22, 2025
Copy link

@hostle83 hostle83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested this and it looks good, thank you @Andrea-Guevara!

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andrea-Guevara : Tested & reviewed this today. Overall, this works and looks good to me. However, there's a small code change that I'd recommend (see below). It's minor, but it avoids our SCSS files overwriting each other with different colors.

Once that change is made, I think this is ready to be merged.

@Andrea-Guevara
Copy link
Contributor Author

Good morning @tdonohue, glad you noticed!
I tried to change the colors in the file “_bootstrap_variables.scss” but looking a little deeper I realized that the variable “$ds-home-news-link-color” is overwritten in the file “_theme_sass_variable_overrides.scss” of the dspace theme, so I modified it directly there!

Anything, we're at your disposal.

Screenshot_75

@tdonohue tdonohue self-requested a review January 24, 2025 14:50
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Andrea-Guevara ! This now looks good to me.

@tdonohue tdonohue merged commit 8cfc61c into DSpace:main Jan 24, 2025
15 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge accessibility bug

Projects

No open projects
Status: ✅ Done

4 participants