Skip to content

Fix - "Browsing by Issue Date" year suppression is confusing as some years are not obviously accessible#3908

Open
VictorDuranEscire wants to merge 5 commits intoDSpace:mainfrom
VictorDuranEscire:dspace-8_3374
Open

Fix - "Browsing by Issue Date" year suppression is confusing as some years are not obviously accessible#3908
VictorDuranEscire wants to merge 5 commits intoDSpace:mainfrom
VictorDuranEscire:dspace-8_3374

Conversation

@VictorDuranEscire
Copy link
Contributor

@VictorDuranEscire VictorDuranEscire commented Jan 28, 2025

Hi @tdonohue , I'm @jtimal partner, I want to share this PR with you

References

Description

After analyzing the incident, I suggest displaying a complete list of available date options in the search component, organizing them according to the existing date ranges in the system. This will facilitate the selection and visualization of available time periods.

Instructions for Reviewers

List of changes in this PR:

  • Elimine la carga actual de opciones a partir del último y primer ítem (Remove current load of options starting from last and first item)
  • Importe el servicio de búsqueda para las opciones por búsqueda facetada (Import search service for faceted search options)
  • Construi las opciones a patir de los resultados de la búsqueda facetada (Build options from faceted search results)

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug component: Discovery related to discovery search or browse system 1 APPROVAL pull request only requires a single approval to merge labels Jan 28, 2025
@tdonohue
Copy link
Member

@VictorDuranEscire : Please create new PRs against the main branch where possible to do so. This PR also appears to be created against an older version of the dspace-8_x branch, because it already has merge conflicts.

@github-actions
Copy link

Hi @VictorDuranEscire,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

# Conflicts:
#	src/app/browse-by/browse-by-date/browse-by-date.component.ts
@VictorDuranEscire VictorDuranEscire changed the base branch from dspace-8_x to main March 2, 2025 08:06
@VictorDuranEscire
Copy link
Contributor Author

Hi @tdonohue, I updated the branch with the main and apply the change from there. Sorry for the error

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VictorDuranEscire : Thanks for this work. I've tested this PR today, and I'm not understanding the improvements with this PR. Even with this PR installed, I see a very large number of years which will all return "No results". So, the behavior seems the same, but more dates are listed?

For instance, on my test machine, I have no test data that dates back to the 1700s or 1800s, but the years in my dropdown start in 1760 and go through the 1800s before I get to the 1900s.
years

Am I misunderstanding how this is supposed to work? Or does this PR maybe also require backend changes to be made?

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 9.0 Release May 2, 2025
@tdonohue tdonohue moved this to 👀 Under Review in DSpace 10.0 Release May 19, 2025
@github-actions
Copy link

Hi @VictorDuranEscire,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: Discovery related to discovery search or browse system merge conflict

Projects

Status: 👀 Under Review

Development

Successfully merging this pull request may close these issues.

"Browsing by Issue Date" year suppression is confusing as some years are not obviously accessible

2 participants