Fix - "Browsing by Issue Date" year suppression is confusing as some years are not obviously accessible#3908
Conversation
|
@VictorDuranEscire : Please create new PRs against the |
|
Hi @VictorDuranEscire, |
# Conflicts: # src/app/browse-by/browse-by-date/browse-by-date.component.ts
|
Hi @tdonohue, I updated the branch with the main and apply the change from there. Sorry for the error |
tdonohue
left a comment
There was a problem hiding this comment.
@VictorDuranEscire : Thanks for this work. I've tested this PR today, and I'm not understanding the improvements with this PR. Even with this PR installed, I see a very large number of years which will all return "No results". So, the behavior seems the same, but more dates are listed?
For instance, on my test machine, I have no test data that dates back to the 1700s or 1800s, but the years in my dropdown start in 1760 and go through the 1800s before I get to the 1900s.

Am I misunderstanding how this is supposed to work? Or does this PR maybe also require backend changes to be made?
|
Hi @VictorDuranEscire, |
Hi @tdonohue , I'm @jtimal partner, I want to share this PR with you
References
Description
After analyzing the incident, I suggest displaying a complete list of available date options in the search component, organizing them according to the existing date ranges in the system. This will facilitate the selection and visualization of available time periods.
Instructions for Reviewers
List of changes in this PR:
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.