Skip to content

[Port dspace-7_x] Made expandable navbar section more keyboard accessible#3924

Merged
tdonohue merged 7 commits intoDSpace:dspace-7_xfrom
alexandrevryghem:made-expandable-navbar-section-more-accessible-7_x
Jan 30, 2025
Merged

[Port dspace-7_x] Made expandable navbar section more keyboard accessible#3924
tdonohue merged 7 commits intoDSpace:dspace-7_xfrom
alexandrevryghem:made-expandable-navbar-section-more-accessible-7_x

Conversation

@alexandrevryghem
Copy link
Member

Port of #3581 to dspace-7_x.

Had to move the @slide animation to prevent focus being lost when tabbing in the expandable section

(cherry picked from commit c08c272)
…pandable menu when hovering outside of it

(cherry picked from commit 05232cd)
(cherry picked from commit 2152bab)
(cherry picked from commit 84df67c)
This change avoids triggering an additional change detection cycle

(cherry picked from commit f7bb830)
…rom automatically focussing on the first element

(cherry picked from commit 82ed3aa)
@alexandrevryghem alexandrevryghem added bug accessibility claimed: Atmire Atmire team is working on this issue & will contribute back funded Task is funded via the DSpace Development Fund labels Jan 29, 2025
@alexandrevryghem alexandrevryghem added this to the 7.6.3 milestone Jan 29, 2025
@alexandrevryghem alexandrevryghem self-assigned this Jan 29, 2025
@tdonohue tdonohue self-requested a review January 30, 2025 14:50
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alexandrevryghem ! Tested this manually and verified it's working properly in 7.x

@tdonohue tdonohue merged commit f01e49f into DSpace:dspace-7_x Jan 30, 2025
15 checks passed
@alexandrevryghem alexandrevryghem deleted the made-expandable-navbar-section-more-accessible-7_x branch January 30, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility bug claimed: Atmire Atmire team is working on this issue & will contribute back funded Task is funded via the DSpace Development Fund

Projects

Development

Successfully merging this pull request may close these issues.

2 participants