Avoid retrieving user suggestions if Researcher profiles are disabled

[toniprieto]

References

• Fixes Error appears in DevTools Console ("doesn't contain the link profiles") when Researcher Profiles disabled #3759

Description

Modification of the effects used by the suggestion feature to avoid retrieving user suggestions if Researcher profiles are disabled.

Instructions for Reviewers

Comment out the key :

researcher-profile.entity-type = Person 

And verify that no error appears in the console when a user authenticates or if the page is reloaded with an authenticated user.

Then, uncomment the key and check that suggestions are still being retrieved. (I'm not using the suggestion feature, I just tested that the function retrieving suggestions is called correctly.)

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

👍 Thanks @toniprieto ! I've verified this fixes the error & still works when Researcher Profiles are also enabled. I don't have a better way of performing this check. I don't see any corresponding /server/api/authz/features endpoint for the Suggestions feature. So, it appears we need to check the existence of researcher-profile.entity-type as you are doing.

I'm going to give others (especially @atarix83 ) about 24 hours to give this a quick glance. After that, I'll merge it. We can always revisit it to clean it up later as necessary, if we find a better solution.

[tdonohue]

NOTE TO SELF: This only needs to be ported to 8.x, because the "suggestions" feature didn't exist in 7.x. This issue doesn't appear to impact 7.x

[dspace-bot]

Successfully created backport PR for dspace-8_x:

• [Port dspace-8_x] Avoid retrieving user suggestions if Researcher profiles are disabled #3954