Skip to content

statistics menu leveling to improve user experience#3952

Open
oscar-escire wants to merge 4 commits intoDSpace:mainfrom
oscar-escire:Issue/1392
Open

statistics menu leveling to improve user experience#3952
oscar-escire wants to merge 4 commits intoDSpace:mainfrom
oscar-escire:Issue/1392

Conversation

@oscar-escire
Copy link
Contributor

References

Add references/links to any related issues or PRs. These may include:

Description

This PR changes the statistics button to a menu with sublevels that, depending on where the user is, shows you more or fewer options.

Instructions for Reviewers

List of changes in this PR:

  • Changed statistics button on main bar to a menu with sublevels.
  • Enabled different subleveles depending where the user is:
    ** To main page allow view main statistics
    ** To community page allow view main statistics and selected community statistics
    ** To collection page allow view main statistics, selected community statistics and selected collection statistics
    ** To collection page allow view main statistics, selected community statistics, selected collection statistics and item selected item statistics

To check this PR:

  1. Over main page you will see the statistics menu, if you pass mouse over it, you will see the statistics allowed options.
  2. A similar behavior will work over community, collection or item page but the allowed options will change when you get deeper on the repo structure

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Copy link
Member

@ybnd ybnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend holding off until #3994 so the menu can be constructed dynamically based on the resolved DSO, instead of statically based on the URL

model: {
type: MenuItemType.LINK,
text: 'menu.section.statistics.collection',
link: 'statistics/collections/:id/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this :id refer to the Item in all cases?

model: {
type: MenuItemType.LINK,
text: 'menu.section.statistics.community',
link: 'statistics/communities/:id/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about hierarchies with multiple Communities?

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 9.0 Release Mar 12, 2025
@oscar-escire
Copy link
Contributor Author

Thanks. I hadn't noticed the error in the :id parameter. I reviewed the PR #3994 and agree that we should wait until this PR is approved to change the menu structure, as it directly impacts the way the menu is built.

Also, once this PR is approved, hierarchies could be considered. I will stay tuned over the PR updates.

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

Hi @oscar-escire,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 👀 Under Review

Development

Successfully merging this pull request may close these issues.

UX statistics links behavior is not consistent with the header behavior

3 participants