statistics menu leveling to improve user experience#3952
Open
oscar-escire wants to merge 4 commits intoDSpace:mainfrom
Open
statistics menu leveling to improve user experience#3952oscar-escire wants to merge 4 commits intoDSpace:mainfrom
oscar-escire wants to merge 4 commits intoDSpace:mainfrom
Conversation
ybnd
suggested changes
Mar 12, 2025
| model: { | ||
| type: MenuItemType.LINK, | ||
| text: 'menu.section.statistics.collection', | ||
| link: 'statistics/collections/:id/', |
Member
There was a problem hiding this comment.
Wouldn't this :id refer to the Item in all cases?
| model: { | ||
| type: MenuItemType.LINK, | ||
| text: 'menu.section.statistics.community', | ||
| link: 'statistics/communities/:id/', |
Member
There was a problem hiding this comment.
What about hierarchies with multiple Communities?
Contributor
Author
|
Thanks. I hadn't noticed the error in the :id parameter. I reviewed the PR #3994 and agree that we should wait until this PR is approved to change the menu structure, as it directly impacts the way the menu is built. Also, once this PR is approved, hierarchies could be considered. I will stay tuned over the PR updates. |
|
Hi @oscar-escire, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Add references/links to any related issues or PRs. These may include:
Description
This PR changes the statistics button to a menu with sublevels that, depending on where the user is, shows you more or fewer options.
Instructions for Reviewers
List of changes in this PR:
** To main page allow view main statistics
** To community page allow view main statistics and selected community statistics
** To collection page allow view main statistics, selected community statistics and selected collection statistics
** To collection page allow view main statistics, selected community statistics, selected collection statistics and item selected item statistics
To check this PR:
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.