Skip to content

Synchronized standalone imports in custom theme#3955

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
alexandrevryghem:w2p-126015_synchronize-standalone-imports-main
Feb 5, 2025
Merged

Synchronized standalone imports in custom theme#3955
tdonohue merged 1 commit intoDSpace:mainfrom
alexandrevryghem:w2p-126015_synchronize-standalone-imports-main

Conversation

@alexandrevryghem
Copy link
Member

Description

Currently when you enable the custom theme, some pages don't work anymore because they have outdated standalone imports. An example of this is the profile page, which throws NG0303: Can't bind to 'ngTemplateOutlet' since it isn't a known property of 'ng-container' (used in the 'ProfilePageComponent' component template).

Instructions for Reviewers

List of changes in this PR:

  • Synchronized all the imports from src/app components with src/themes/custom
  • Also removed some unused imports from the dspace theme

Include guidance for how to test or review your PR.

  • Set the theme to custom in config.yml
  • Uncomment the CustomEagerThemeModule in src/themes/eager-themes.module.ts
  • Go to the profile page for example and verify not error is thrown in the console anymore due to those missing imports, do this for all the components which had outdated imports

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem added bug themes port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Feb 5, 2025
@alexandrevryghem alexandrevryghem added this to the 9.0 milestone Feb 5, 2025
@alexandrevryghem alexandrevryghem self-assigned this Feb 5, 2025
@alexandrevryghem alexandrevryghem changed the title 126015: Sync standalone imports in custom theme Synchronized standalone imports in custom theme Feb 5, 2025
@tdonohue
Copy link
Member

tdonohue commented Feb 5, 2025

@alexandrevryghem : I tested the existing behavior on dspace-8_x and cannot reproduce the error you noted on that branch when enabling the custom theme and CustomEagerThemeModule. Does this error possibly only impact main?

If this truly impacts dspace-8_x, then we may want to merge this quickly (in time for 8.1)...but I'm not finding any impact on that branch.

@alexandrevryghem
Copy link
Member Author

@tdonohue: I can reproduce it on the latest version of dspace-8_x as well. Another example is the create community popup:

Screen.Recording.2025-02-05.at.19.49.59.mov

@tdonohue
Copy link
Member

tdonohue commented Feb 5, 2025

@alexandrevryghem : Thanks for the additional example. I am able to reproduce the "New -> Community" issue (no popup appears with an error in the console).

I'll give this an immediate review/test & try to get it into 8.1.

@tdonohue tdonohue self-requested a review February 5, 2025 19:55
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alexandrevryghem ! I was able to verify the bug on both main and dspace-8_x. I've also verified this fixes the issue on both branches

@tdonohue tdonohue merged commit 542e2db into DSpace:main Feb 5, 2025
15 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@alexandrevryghem alexandrevryghem deleted the w2p-126015_synchronize-standalone-imports-main branch February 5, 2025 21:37
@alexandrevryghem alexandrevryghem removed the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants