Synchronized standalone imports in custom theme#3955
Conversation
|
@alexandrevryghem : I tested the existing behavior on If this truly impacts |
|
@tdonohue: I can reproduce it on the latest version of Screen.Recording.2025-02-05.at.19.49.59.mov |
|
@alexandrevryghem : Thanks for the additional example. I am able to reproduce the "New -> Community" issue (no popup appears with an error in the console). I'll give this an immediate review/test & try to get it into 8.1. |
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! I was able to verify the bug on both main and dspace-8_x. I've also verified this fixes the issue on both branches
|
Successfully created backport PR for |
Description
Currently when you enable the custom theme, some pages don't work anymore because they have outdated standalone imports. An example of this is the profile page, which throws
NG0303: Can't bind to 'ngTemplateOutlet' since it isn't a known property of 'ng-container' (used in the 'ProfilePageComponent' component template).Instructions for Reviewers
List of changes in this PR:
src/appcomponents withsrc/themes/customInclude guidance for how to test or review your PR.
custominconfig.ymlCustomEagerThemeModuleinsrc/themes/eager-themes.module.tsChecklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.