Add citation_doi tag to head meta#4034
Merged
kshepherd merged 2 commits intoDSpace:dspace-7_xfrom Mar 6, 2025
Merged
Conversation
tdonohue
added
port to main
alanorth
force-pushed
the
7_x-citation-doi
branch
from
a022123 to
20ae5fc
Compare
This was referenced Feb 26, 2025
tdonohue
added
the
1 APPROVAL
alanorth
force-pushed
the
7_x-citation-doi
branch
from
20ae5fc to
9f00813
Compare
This is used by harvesters like Altmetric and was present in DSpace version 6 and previous.
Remove commented out this.setCitationDOITag() since it is not used and we use camel case with this.setCitationDoiTag() now anyway.
alanorth
force-pushed
the
7_x-citation-doi
branch
from
9f00813 to
204556d
Compare
tdonohue
moved this to 🙋 Needs Reviewers Assigned
in DSpace Maintenance (9.x, 8.x, 7.6.x)
alanorth
removed
port to dspace-8_x
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace Maintenance (9.x, 8.x, 7.6.x)
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace Maintenance (9.x, 8.x, 7.6.x)
Member
|
@alanorth |
Contributor
Author
|
Thanks @kshepherd. I removed the port tags because I manually ported these but forgot to mention them here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Add references/links to any related issues or PRs. These may include:
Description
Add missing
<meta name="citation_doi" ...>fields to the XHTML head section for items that have DOIs. This is used by harvesters like Altmetric to monitor attention on identifiers in repositories and academic publishers.Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
<meta name="citation_doi" content=...>tag to the<head>section item pages containing a DOI in thedc.identifier.doifield (default).This will need to be ported to DSpace 8+ manually.
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Check the HTML source in the browser inspector on a simple item view page for an item that has a DOI. You should see a new meta tag for
citation_doi.Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.