Skip to content

[Port dspace-8_x] #10053: Add support for PCI Endorsement workflow #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdonohue merged 2 commits into from
Mar 17, 2025
Merged

[Port dspace-8_x] #10053: Add support for PCI Endorsement workflow #4037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1037d8
Port #10053: Notify PCI endorsement support (DSpace 8.x)
amgciadev Feb 25, 2025
1b0e992
Change label quality-assurance.event.table.event.message.serviceUrl t…
amgciadev Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/app/core/data/signposting-links.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
export interface SignpostingLink {
href?: string,
rel?: string,
type?: string
type?: string,
profile?: string
}
8 changes: 7 additions & 1 deletion src/app/item-page/simple/item-page.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@
this.signpostingLinks = signpostingLinks;

signpostingLinks.forEach((link: SignpostingLink) => {
links = links + (isNotEmpty(links) ? ', ' : '') + `<${link.href}> ; rel="${link.rel}"` + (isNotEmpty(link.type) ? ` ; type="${link.type}" ` : ' ');
links = links + (isNotEmpty(links) ? ', ' : '') + `<${link.href}> ; rel="${link.rel}"` + (isNotEmpty(link.type) ? ` ; type="${link.type}" ` : ' ')
+ (isNotEmpty(link.profile) ? ` ; profile="${link.profile}" ` : '');
let tag: LinkDefinition = {
href: link.href,
rel: link.rel,
Expand All @@ -178,6 +179,11 @@
type: link.type,
});
}
if (isNotEmpty(link.profile)) {
tag = Object.assign(tag, {

Check warning on line 183 in src/app/item-page/simple/item-page.component.ts

View check run for this annotation

Codecov / codecov/patch

src/app/item-page/simple/item-page.component.ts#L183 

Added line #L183 was not covered by tests
profile: link.profile,
});
}
this.linkHeadService.addTag(tag);
});

Expand Down
1 change: 1 addition & 0 deletions src/app/item-page/simple/notify-requests-status/notify-status.enum.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ export enum RequestStatusEnum {
ACCEPTED = 'ACCEPTED',
REJECTED = 'REJECTED',
REQUESTED = 'REQUESTED',
TENTATIVE_REJECT = 'TENTATIVE_REJECT',
}
7 changes: 7 additions & 0 deletions ...ple/notify-requests-status/request-status-alert-box/request-status-alert-box.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@
};
break;

case RequestStatusEnum.TENTATIVE_REJECT:
this.displayOptions = {

Check warning on line 78 in src/app/item-page/simple/notify-requests-status/request-status-alert-box/request-status-alert-box.component.ts

View check run for this annotation

Codecov / codecov/patch

src/app/item-page/simple/notify-requests-status/request-status-alert-box/request-status-alert-box.component.ts#L78 

Added line #L78 was not covered by tests
alertType: 'alert-warning',
text: 'request-status-alert-box.tentative_rejected',
};
break;

Check warning on line 82 in src/app/item-page/simple/notify-requests-status/request-status-alert-box/request-status-alert-box.component.ts

View check run for this annotation

Codecov / codecov/patch

src/app/item-page/simple/notify-requests-status/request-status-alert-box/request-status-alert-box.component.ts#L82 

Added line #L82 was not covered by tests

case RequestStatusEnum.REQUESTED:
this.displayOptions = {
alertType: 'alert-warning',
Expand Down
4 changes: 3 additions & 1 deletion src/assets/i18n/en.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6318,7 +6318,7 @@

"quality-assurance.events.description-with-topic-and-target": "Below the list of all the suggestions for the selected topic <b>{{topic}}</b>, related to <b>{{source}}</b> and ",

"quality-assurance.event.table.event.message.serviceUrl": "Service URL:",
"quality-assurance.event.table.event.message.serviceUrl": "Actor:",

"quality-assurance.event.table.event.message.link": "Link:",

Expand Down Expand Up @@ -6382,6 +6382,8 @@

"request-status-alert-box.rejected": "The requested {{ offerType }} for <a href='{{serviceUrl}}' target='_blank'> {{ serviceName }} </a> has been rejected.",

"request-status-alert-box.tentative_rejected": "The requested {{ offerType }} for <a href='{{serviceUrl}}' target='_blank'> {{ serviceName }} </a> has been tentatively rejected. Revisions are required.",

"request-status-alert-box.requested": "The requested {{ offerType }} for <a href='{{serviceUrl}}' target='_blank'> {{ serviceName }} </a> is pending.",

"ldn-service-button-mark-inbound-deletion": "Mark supported pattern for deletion",
Expand Down
Loading