System Wide Alerts should send countdown date to REST API in ISO-8601 format#4039
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Mar 11, 2025
Merged
System Wide Alerts should send countdown date to REST API in ISO-8601 format#4039tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue merged 1 commit intoDSpace:mainfrom
Conversation
tdonohue
added
component: administrative tools
tdonohue
commented
Mar 11, 2025
Member
Author
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
Appoved via testing of DSpace/DSpace#10432, see DSpace/DSpace#10432 (comment)
Merging immediately as DSpace/DSpace#10432 was just approved & merged.
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to ✅ Done
in DSpace 9.0 Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
java.util.Dateandjava.util.Calendartojava.time.*Date classes DSpace#10432 for System Wide Alerts to work properlyDescription
Currently, if you set a "countdown timer" on the System-Wide Alert page, the date is sent to the REST API in a non-standard format that looks like this:
Thu, 14 Nov 2019 00:55:16 GMTThis format seems to work fine for the current codebase, but it cannot be parsed by the backend if you use PR DSpace/DSpace#10432
This small PR updates the date to be sent in ISO-8601 format, e.g.
2019-11-14T00:55:31.820Z, which is required by DSpace/DSpace#10432Instructions for Reviewers
java.util.Dateandjava.util.Calendartojava.time.*Date classes DSpace#10432