apply spellCheck configuration to input model#4057
Merged
tdonohue merged 3 commits intoDSpace:mainfrom Apr 30, 2025
Merged
Conversation
tdonohue
added
improvement
1 APPROVAL
tdonohue
approved these changes
Apr 30, 2025
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @saschaszott ! Stumbled on this today, and it's a tiny useful improvement. I tested it and verified that input boxes (onebox) now have spell check capabilities in the submission form.
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 9.0 Release
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 9.0 Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this PR, the
spellCheckattribute is also applied to simple input fields based on the application configurationform.spellCheck. Currently, thespellCheckattribute is only set for textarea fields (see #2003).