Skip to content

Minor fixes to Cypress e2e tests#4069

Merged
tdonohue merged 2 commits intoDSpace:mainfrom
tdonohue:fix_e2e_tests
Mar 12, 2025
Merged

Minor fixes to Cypress e2e tests#4069
tdonohue merged 2 commits intoDSpace:mainfrom
tdonohue:fix_e2e_tests

Conversation

@tdonohue
Copy link
Member

Description

This small PR fixes two small issues with Cypress e2e tests:

Instructions for Reviewers

  • The first change will be auto-tested by this PR. If the accessibility check succeeds, then this fix is correct.
  • The second changes is most easily tested in VS Code by opening any *.cy.ts file in the cypress directory. Currently, on main, if you open one of these files, a lot of the type definitions will be unrecognized & you'll see red lines in the opened files. However, with this PR in place, those red lines go away.

NOTE: There are no direct changes to DSpace in this PR. The two small changes only impact e2e tests.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge testing framework Related specifically to Unit or Integration (e2e) Tests labels Mar 10, 2025
@tdonohue tdonohue added this to the 9.0 milestone Mar 10, 2025
Copy link
Member Author

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this immediately as this doesn't modify any DSpace code, just tests & all tests pass.

Plus, the minor changes to the cypress tsconfig.json finally fix some annoying issues with editing our e2e tests in IDEs. If anyone finds issues later on, I'll gladly fix them up.

@tdonohue tdonohue merged commit b44b7a6 into DSpace:main Mar 12, 2025
15 checks passed
@tdonohue tdonohue deleted the fix_e2e_tests branch March 12, 2025 21:34
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Feb 10, 2026
[CST-2710] avoid using empty user value as valid user

Approved-by: Francesco Molinaro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge testing framework Related specifically to Unit or Integration (e2e) Tests

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant