Merged
Conversation
Addition of french translations for Duplicate detection, ROR and Advanced search features.
nimabehforouz
approved these changes
Apr 8, 2025
Contributor
nimabehforouz
left a comment
nimabehforouz
left a comment
There was a problem hiding this comment.
All French translations reviewed and verified.
tdonohue
requested changes
Apr 8, 2025
src/assets/i18n/fr.json5
Outdated
| "search.filters.operator.equals.text": "Est égal à", | ||
|
|
||
| //"search.filters.operator.notequals.text": "Not Equals", | ||
| search.filters.operator.notequals.text": "N'est pas égal à", |
Member
There was a problem hiding this comment.
This line is missing a quote (") at the very beginning
src/assets/i18n/fr.json5
Outdated
| "search.filters.operator.authority.text": "Est une autorité", | ||
|
|
||
| //"search.filters.operator.notauthority.text": "Not Authority", | ||
| "search.filters.operator.notauthority.text": "N'est pas une autorité" |
Member
There was a problem hiding this comment.
This line is missing a trailing comma (,)
Contributor
Author
There was a problem hiding this comment.
Done. Thanks @tdonohue for pointing me out the 2 errors.
tdonohue
added
i18n / l10n
tdonohue
added
the
port to dspace-8_x
tdonohue
approved these changes
Apr 9, 2025
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @pilasou ! This looks good to me as well, and already has approval from @nimabehforouz . So, I'm merging immediately.
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 9.0 Release
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 9.0 Release
Contributor
|
Successfully created backport PR for |
tdonohue
removed
the
port to dspace-8_x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of french translations for Duplicate detection, ROR and Advanced search features.