Skip to content

Filters disappeared on reload#4077

Merged
alanorth merged 1 commit intoDSpace:dspace-7_xfrom
arvoConsultores:DS-4053
Mar 14, 2025
Merged

Filters disappeared on reload#4077
alanorth merged 1 commit intoDSpace:dspace-7_xfrom
arvoConsultores:DS-4053

Conversation

@anaparvo
Copy link
Contributor

References

Fix #4053

Description

The component does not detect navigation changes.

Instructions for Reviewers

  • Search for something in the searchbar
  • Click on the second page
  • Now the filters works

List of changes in this PR:

  • SearchFiltersComponent

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@anaparvo anaparvo changed the base branch from main to dspace-7_x March 13, 2025 09:18
@alanorth
Copy link
Contributor

Thanks @anaparvo! I tested this briefly just now and this patch resolves the issue for me.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge labels Mar 13, 2025
@tdonohue tdonohue added this to the 7.6.4 milestone Mar 13, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace Maintenance (9.x, 8.x, 7.6.x) Mar 13, 2025
@tdonohue
Copy link
Member

Closing & reopening this PR to trigger GitHub actions to run properly. For some reason the automated tests didn't run for this PR, and usually closing & reopening will trigger them to rerun.

@tdonohue tdonohue closed this Mar 13, 2025
@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) Mar 13, 2025
@tdonohue tdonohue reopened this Mar 13, 2025
@tdonohue tdonohue moved this from ✅ Done to 🙋 Needs Reviewers Assigned in DSpace Maintenance (9.x, 8.x, 7.6.x) Mar 13, 2025
@ovali
Copy link

ovali commented Mar 14, 2025

I tested this and can confirm the filters show up.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace Maintenance (9.x, 8.x, 7.6.x) Mar 14, 2025
@alanorth alanorth merged commit d65ff20 into DSpace:dspace-7_x Mar 14, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) Mar 14, 2025
@alanorth
Copy link
Contributor

Thanks @anaparvo! Merging this ASAP as it's a simple fix that has been tested by two users and is passing all tests.

atarix83 pushed a commit to 4Science/dspace-angular that referenced this pull request Feb 20, 2026
[CST-24688] modified en.json5

Approved-by: Daniele Ninfo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug high priority

Projects

Development

Successfully merging this pull request may close these issues.

7.6.3 - Search facet filters reload or cache problem after changing search term on results page

4 participants