Open
Conversation
tdonohue
requested changes
Mar 24, 2025
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
@siyamex : Thanks for this contribution! Just as a note, this appears to currently be failing our build process because the npm run lint command is throwing errors that say your dv.json5 file is incorrectly formatted.
I believe I've found the issue below (see my inline comment)
| "cookies.consent.purpose.functional": "ފަންކްޝަނަލް", | ||
| "cookies.consent.purpose.statistical": "ސްޓެޓިސްޓިކަލް", | ||
| "cookies.consent.purpose.registration-password-recovery": "ރެޖިސްޓްރޭޝަންކުރުމާއި ޕާސްވޯރޑް ރިކަވަރީކުރުން", | ||
| "cookies.consent.purpose.sharing": "ހިއްސާކުރަނީ" |
Member
There was a problem hiding this comment.
This line is missing the trailing comma (,). If you add a comma to the end of this line, that should fix the formatting errors.
tdonohue
added
i18n / l10n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dhivehi translate files added