Merged
Conversation
added 2 commits
April 4, 2025 14:30
…cleanup-input-form-spacing_contribute-main
tdonohue
added
component: submission
1 APPROVAL
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 9.0 Release
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 9.0 Release
alexandrevryghem
deleted the
w2p-127705_cleanup-input-form-spacing_contribute-main
branch
Contributor
|
Thanks @gingyx. Can this be ported to DSpace 7 and 8? |
alanorth
added a commit
to alanorth/dspace-angular
that referenced
this pull request
Apr 12, 2025
Manual port of DSpace#4136 by @4136 to DSpace 7.x.
alanorth
added a commit
to alanorth/dspace-angular
that referenced
this pull request
Apr 12, 2025
Manual port of DSpace#4136 by @gingyx to DSpace 7.x.
alanorth
added a commit
to alanorth/dspace-angular
that referenced
this pull request
Apr 12, 2025
Manual port of DSpace#4136 by @gingyx to DSpace 7.x.
12 tasks
tdonohue
pushed a commit
to tdonohue/dspace-angular
that referenced
this pull request
Sep 10, 2025
Manual port of DSpace#4136 by @gingyx to DSpace 7.x.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR standardizes spacing values for all input form fields and improves input form readability.
Instructions for Reviewers
List of changes in this PR:
ds-dynamic-form-control-container.component.htmlto reduce bottom margins on field labels and to remove excess spacing between fields.ds-dynamic-form-control-container.component.scssto conform error message margins to hint margins.ds-dynamic-form-control-container.component.scssto conform label padding and margins on non-repeatable tag fields to other fields.existing-metadata-list-element.component.html.date-picker.component.scssto conform bottom margin on date field labels to other labels.BEFORE
AFTER
How to test or review the PR:
Checklist
My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
My PR is created against the
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).My PR passes ESLint validation using
npm run lintMy PR doesn't introduce circular dependencies (verified via
npm run check-circ-deps)My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
My PR aligns with Accessibility guidelines if it makes changes to the user interface.
My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
If my PR fixes an issue ticket, I've linked them together.