Skip to content

Added the DSO menus back to the comcol search tabs#4138

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
alexandrevryghem:w2p-130080_fix-missing-dso-buttons-on-comcol-page_contribute-7.6
Apr 9, 2025
Merged

Added the DSO menus back to the comcol search tabs#4138
tdonohue merged 1 commit intoDSpace:mainfrom
alexandrevryghem:w2p-130080_fix-missing-dso-buttons-on-comcol-page_contribute-7.6

Conversation

@alexandrevryghem
Copy link
Member

References

Description

Fixed issue where the DSO menus were hidden on the comcol search tabs. This issue is a side effect of the merge between #3994 & #3164

Instructions for Reviewers

List of changes in this PR:

  • Added the necessary data on the /search route from the community & collection routes to generate the DSO menus there as well

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem added bug component: Community Community display or editing component: Collection Collection display or editing testathon Reported by a tester during Community Testathon labels Apr 8, 2025
@alexandrevryghem alexandrevryghem added this to the 9.0 milestone Apr 8, 2025
@alexandrevryghem alexandrevryghem self-assigned this Apr 8, 2025
@alexandrevryghem alexandrevryghem moved this to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release Apr 8, 2025
@tdonohue tdonohue self-requested a review April 9, 2025 14:13
@tdonohue tdonohue moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 9.0 Release Apr 9, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alexandrevryghem for the quick fix! I tested this and verified it fixes the bug

@github-project-automation github-project-automation bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 9.0 Release Apr 9, 2025
@tdonohue tdonohue merged commit d6261e4 into DSpace:main Apr 9, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 9.0 Release Apr 9, 2025
@alexandrevryghem alexandrevryghem deleted the w2p-130080_fix-missing-dso-buttons-on-comcol-page_contribute-7.6 branch April 9, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug component: Collection Collection display or editing component: Community Community display or editing testathon Reported by a tester during Community Testathon

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Subscribe / Edit button options no longer appear on Community / Collection "Search" tab

2 participants