Fix pagination on the "Select bitstreams" modal of the "Access Control" tab#4143
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Apr 11, 2025
Conversation
…-bitstreams-pagination-fix-7.6' into w2p-130081_access-control-bitstreams-pagination-fix-main Conflicts: src/app/shared/access-control-form-container/item-access-control-select-bitstreams-modal/item-access-control-select-bitstreams-modal.component.html src/app/shared/access-control-form-container/item-access-control-select-bitstreams-modal/item-access-control-select-bitstreams-modal.component.ts
nona-luypaert
added
bug
component: Item
tdonohue
moved this from 🙋 Needs Reviewers Assigned
to 👀 Under Review
in DSpace 9.0 Release
tdonohue
approved these changes
Apr 11, 2025
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @nona-luypaert ! Tested this today and it fixes the bug. This PR will need to be manually backported to 7.x and 8.x because the code syntax of this PR would be different in those older versions.
Could you create a 7.x and 8.x version of this PR in order to backport it?
github-project-automation
bot
moved this from 👀 Under Review
to 👍 Reviewer Approved
in DSpace 9.0 Release
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 9.0 Release
Contributor
|
Successfully created backport PR for |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-4143-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-4143-to-dspace-8_x
git switch --create backport-4143-to-dspace-8_x
git cherry-pick -x c03bbb01a2d4ebdedacff3b046a7ce0522bf971f |
artlowel
removed
port to dspace-7_x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Fixed pagination on the "Select bitstreams" modal of the "Edit Item > Access Control" page.
Instructions for Reviewers
Changes
Refactored ItemAccessControlSelectBitstreamsModalComponent to:
Include guidance for how to test or review your PR.
/edit/access-controlpage of that item.Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.