Skip to content

Ensure all i18n files are up to date with the english version#4163

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:sync-i18n-files
Apr 10, 2025
Merged

Ensure all i18n files are up to date with the english version#4163
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:sync-i18n-files

Conversation

@artlowel
Copy link
Member

References

None

Description

I ran npm run sync-i18n. This will update all the i18n files based on the added and changed keys in the english file. There will be // TODO comments for every key that needs to be updated in those languages files.

Instructions for Reviewers

Nothing should look different. Missing keys would already fallback to english. The only difference is that they are now directly in the other language files as well

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@artlowel artlowel added the i18n / l10n Internationalisation and localisation, related to message catalogs label Apr 10, 2025
@artlowel artlowel requested a review from tdonohue April 10, 2025 14:18
@artlowel artlowel self-assigned this Apr 10, 2025
@artlowel artlowel moved this to 👀 Under Review in DSpace 9.0 Release Apr 10, 2025
@artlowel artlowel added this to the 9.0 milestone Apr 10, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @artlowel ! This looks good/correct. I gave it a quick sanity check because this is so large, but everything is working & the changes are primarily cosmetic / formatting. It looks like we haven't run this in a long time.

I've also added a note the the Release Procedure that we may want to run this prior to every new release (to keep these files better synced): https://wiki.lyrasis.org/display/DSPACE/Release+Procedure#ReleaseProcedure-UpdateUserInterfaceLanguagePacksfiles (That will be my reminder that this needs to be run regularly)

@github-project-automation github-project-automation bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 9.0 Release Apr 10, 2025
@tdonohue tdonohue merged commit 42b567f into DSpace:main Apr 10, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 9.0 Release Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants