Ensure all i18n files are up to date with the english version#4163
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Apr 10, 2025
Merged
Ensure all i18n files are up to date with the english version#4163tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue merged 1 commit intoDSpace:mainfrom
Conversation
…e english version
tdonohue
approved these changes
Apr 10, 2025
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @artlowel ! This looks good/correct. I gave it a quick sanity check because this is so large, but everything is working & the changes are primarily cosmetic / formatting. It looks like we haven't run this in a long time.
I've also added a note the the Release Procedure that we may want to run this prior to every new release (to keep these files better synced): https://wiki.lyrasis.org/display/DSPACE/Release+Procedure#ReleaseProcedure-UpdateUserInterfaceLanguagePacksfiles (That will be my reminder that this needs to be run regularly)
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
None
Description
I ran
npm run sync-i18n. This will update all the i18n files based on the added and changed keys in the english file. There will be // TODO comments for every key that needs to be updated in those languages files.Instructions for Reviewers
Nothing should look different. Missing keys would already fallback to english. The only difference is that they are now directly in the other language files as well
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.