Skip to content

Wrap long bitstream filenames#4164

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:edit-bitstream-word-wrap
Apr 10, 2025
Merged

Wrap long bitstream filenames#4164
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:edit-bitstream-word-wrap

Conversation

@artlowel
Copy link
Member

References

Description

I added our existing dont-break-out css class to the header on the edit bitstream page. I also noticed the same issue in the bitstreams tab on the edit item page, so I added it there as well

Instructions for Reviewers

  • Create a bitstream with a very long name, either by uploading a new one, or editing the name of an existing one
  • verify that the name now wraps, instead of moving off screen

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@artlowel artlowel added bug component: Item (Archived) Item display or editing testathon Reported by a tester during Community Testathon labels Apr 10, 2025
@artlowel artlowel added this to the 9.0 milestone Apr 10, 2025
@artlowel artlowel self-assigned this Apr 10, 2025
@artlowel artlowel moved this to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release Apr 10, 2025
@artlowel artlowel added the 1 APPROVAL pull request only requires a single approval to merge label Apr 10, 2025
@tdonohue tdonohue self-requested a review April 10, 2025 19:16
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @artlowel ! Verified this fixes the bug.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 9.0 Release Apr 10, 2025
@tdonohue tdonohue merged commit b7a130c into DSpace:main Apr 10, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 9.0 Release Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: Item (Archived) Item display or editing testathon Reported by a tester during Community Testathon

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Bitstream with long name exceeds screen borders on the Edit item -> Bitstreams -> Upload page

2 participants