Add additional automated server-side rendering (SSR) tests for all Entity Types#4189
Merged
kshepherd merged 1 commit intoDSpace:mainfrom Apr 15, 2025
Merged
Conversation
…tion/Item, Person, OrgUnit and all Journal entities
tdonohue
added
1 APPROVAL
Member
Author
|
@kshepherd : Would you be willing to give this a quick review? I've verified that this would have caught the issues in #4145 if we'd had this in place. So, now future PRs will be automatically verified to not break SSR on major pages. |
Member
|
@tdonohue will review this tomorrow with priority, thanks! |
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 9.0 Release
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 9.0 Release
Contributor
|
Git push to origin failed for dspace-7_x with exitcode 1 |
Contributor
|
Git push to origin failed for dspace-8_x with exitcode 1 |
tdonohue
removed
port to dspace-7_x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
After #4145 was discovered by accident, I thought it'd be better to add more automated SSR testing to our GitHub CI process. This PR therefore adds an SSR validation test for Communities, Collections, Items/Publication, Person, Project, OrgUnit and all Journal entity types.
The new tests are based on the existing SSR test that we've had for the Homepage already.
I've verified these new tests would have caught the issue found in #4145 by doing the following:
wgetcommand for a Publication entity included in this PR.The
wgetcommand fails (returns 1) if #4161 is reverted, but succeeds (returns 0) on main.Instructions for Reviewers
wgettests pass