[Port dspace-7_x] Show restricted thumbnails to users with access rights#4250
Merged
tdonohue merged 6 commits intoDSpace:dspace-7_xfrom May 8, 2025
Merged
Conversation
…r users with access rights
…-thumbnails_contribute-7.6
8 tasks
0554caf to
cfc7df5
Compare
…iewer, and switch to themed version of thumbnail component
cfc7df5 to
283b345
Compare
tdonohue
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
There was already a call to get a shortlivedtoken in the thumbnail component. The issue was that in prod mode, angular didn't detect that the image src had changed afterwards so it didn't rerender the image.
The solution was to use a BehaviorSubject for the src and the isLoading boolean
Instructions for Reviewers
filter-media -f -i ${the item's handle}on the item containing the bitstreamChecklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.