[Port dspace-8_x] Made AdminSearchPageComponent themeable #4385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch-page_contribute-7.4' into w2p-131441_backport-3065-8
alexandrevryghem
added
bug
accessibility
component: Discovery
alexandrevryghem
moved this to 🙋 Needs Reviewers Assigned
in DSpace Maintenance (9.x, 8.x, 7.6.x)
Member
|
Automated tests failed to run. So, I'm closing this temporarily & reopening in order to re-trigger them. |
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to ✅ Done
in DSpace Maintenance (9.x, 8.x, 7.6.x)
tdonohue
moved this from ✅ Done
to 👀 Under Review
in DSpace Maintenance (9.x, 8.x, 7.6.x)
tdonohue
moved this from 👀 Under Review
to 🙋 Needs Reviewers Assigned
in DSpace Maintenance (9.x, 8.x, 7.6.x)
Member
|
@AbhinavS96 : This PR seems to be having build errors. |
Also fixed minor issue in MetadataService, but this doesn't cause any issues in the current code (cherry picked from commit 446280b)
tdonohue
approved these changes
May 30, 2025
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @AbhinavS96 ! This port looks good to me. I gave it a manual test to verify no issues and I didn't find anything.
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace Maintenance (9.x, 8.x, 7.6.x)
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace Maintenance (9.x, 8.x, 7.6.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #3065 by @alexandrevryghem