Confirmation dialog before deleting Group

[jlipka]

References

• Fixes #4346

Description

Display a confirmation dialogue before deleting a group. The text has been extended to make it clear that all associated policies of the group will also be deleted.

Instructions for Reviewers

Confirm dialog added or extended at three places - these places could be tested during the review process:

1. "Access Control" > "Groups" (Delete Button in listing - appears only if deletable)
2. "Access Control" > "Groups" > Edit ("Delete Group" button next to "Save" button, only if deletable)
3. "Edit" > "Collection" > (Choose any collection) > "Assign Roles" (Delete button next to each existing role)

List of changes in this PR:

• Reused the already existing "ConfirmationModalComponent"
• Tests extended to cover the changed behaviour
• Translations added

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[alanorth]

Thanks @jlipka. This works well. I tested it on sandbox.dspace.org on the three admin screens where deleting a user is possible.

Only small feedback is the text overflowing on deleting a workflow group. I was in Firefox if it makes a difference.

[pcg-kk]

Work as expected - no other issue than reported by @alanorth - the X is going outside of the container when text is going outside.

[jlipka]

Only small feedback is the text overflowing on deleting a workflow group. I was in Firefox if it makes a difference.

I just added some css code to make sure any long word will break to new line:

[alanorth]

Thanks for the code @jlipka. I have tested again and the text does not overflow anymore. This is now at +2 with @pcg-kk and my review. Looks good to me!

Heads up: I will tag this for automatic porting to DSpace 7, 8, and 9, but I'm expecting 7 and 8 to fail so we'll need to port it manually.

[dspace-bot]

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-4389-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-4389-to-dspace-7_x
git switch --create backport-4389-to-dspace-7_x
git cherry-pick -x 57bf254bec793800ba6c8d1ccd00b5513b5e528a 137bbc35bd93c76e1f841f33100b59aa52bcc6b8 55d2f0ce38be01a435d68e743c0b60666996d3bc 20510591e439fa68238c6b245d87413e916a458c

[dspace-bot]

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-4389-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-4389-to-dspace-8_x
git switch --create backport-4389-to-dspace-8_x
git cherry-pick -x 57bf254bec793800ba6c8d1ccd00b5513b5e528a 137bbc35bd93c76e1f841f33100b59aa52bcc6b8 55d2f0ce38be01a435d68e743c0b60666996d3bc 20510591e439fa68238c6b245d87413e916a458c

[dspace-bot]

Successfully created backport PR for dspace-9_x:

• [Port dspace-9_x] Confirmation dialog before deleting Group #4455

[jlipka]

Hey @tdonohue
I tried to create a backport (for the first time) for DSpace version 8 - i am not really 100% sure if everything did go right: #4479

[tdonohue]

@jlipka : Your backport was unfortunately not accurate. I added a comment to #4479 (comment) with a few minor suggestions.

To be honest, if we find this fix is too complex to backport, then we can simply mark it as "fixed in 9.1" (I've done that for now). If another developer wants to backport it themselves at a later time if they desire.