Skip to content

[Port dspace-7_x] Improve accessibility for screen readers#4417

Merged
tdonohue merged 8 commits intoDSpace:dspace-7_xfrom
atmire:w2p-131442_backport-4335-to-dspace-7_x
Jul 3, 2025
Merged

[Port dspace-7_x] Improve accessibility for screen readers#4417
tdonohue merged 8 commits intoDSpace:dspace-7_xfrom
atmire:w2p-131442_backport-4335-to-dspace-7_x

Conversation

@gingyx
Copy link

@gingyx gingyx commented Jun 2, 2025

Port of #4335 by @alexandrevryghem to dspace-7_x .

…heme

- Replaced the menubar role from the parent of all the header buttons like lang switch, auth menu & help toggle with toolbar
- Replaced the remaining `<a>` buttons in the header with `<button>` to make them expandable with space
- Fixed accessibility issues flagged by axe DevTools in the user menu dropdown
@gingyx gingyx force-pushed the w2p-131442_backport-4335-to-dspace-7_x branch from d12b23b to b6448a7 Compare June 2, 2025 11:55
@tdonohue
Copy link
Member

tdonohue commented Jul 2, 2025

@gingyx : Is this backport ready for review? I just stumbled on it, but it looks like the PR is still in "Draft" state. Just checking in to see if you forget to click the "Ready for review" button.

@gingyx gingyx marked this pull request as ready for review July 3, 2025 08:54
@gingyx
Copy link
Author

gingyx commented Jul 3, 2025

@tdonohue Thanks for pointing that out! Marked as ready for review.

@tdonohue tdonohue added this to the 7.6.4 milestone Jul 3, 2025
@tdonohue tdonohue moved this to 👀 Under Review in DSpace Maintenance (9.x, 8.x, 7.6.x) Jul 3, 2025
@tdonohue tdonohue self-requested a review July 3, 2025 18:48
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @gingyx ! I've verified this is the same code as in #4335, but backported to 7.x syntax. I gave these various components a test from the UI (to verify no changes in behavior) and everything looks good to me.

@github-project-automation github-project-automation bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace Maintenance (9.x, 8.x, 7.6.x) Jul 3, 2025
@tdonohue tdonohue merged commit 0d87a72 into DSpace:dspace-7_x Jul 3, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants

Comments