Skip to content

Remove zone.js dependency#4422

Closed
alanorth wants to merge 1 commit intoDSpace:dspace-7_xfrom
alanorth:7_x-remove-zone.js
Closed

Remove zone.js dependency#4422
alanorth wants to merge 1 commit intoDSpace:dspace-7_xfrom
alanorth:7_x-remove-zone.js

Conversation

@alanorth
Copy link
Contributor

@alanorth alanorth commented Jun 4, 2025

Description

We do not use this directly and it seems to be a transitive dependency of Angular, so we should let Angular pull in the version it wants. You can see this causes dependency conflicts in the recent dependabot pull requests updating zone.js.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • Remove zone.js dependency from package.json and yarn.lock

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Make sure all tests in CI pass.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

We do not use this directly and it seems to be a transitive dep of
Angular, so we should let Angular pull in the version it wants.
@alanorth alanorth added dependencies Pull requests that update a dependency file 1 APPROVAL pull request only requires a single approval to merge labels Jun 4, 2025
@alanorth
Copy link
Contributor Author

alanorth commented Jun 4, 2025

Ah, now I see we use it in src/main.browser.ts and src/main.server.ts for example. I was previously only looking in src/app.

@alanorth alanorth closed this Jun 4, 2025
@alanorth alanorth deleted the 7_x-remove-zone.js branch June 4, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant