Lazy-load geospatial map code (9.x)#4447
Merged
kshepherd merged 3 commits intoDSpace:dspace-9_xfrom Jun 12, 2025
Merged
Conversation
ybnd
added
the
performance / caching
ybnd
changed the title
According to the Angular docs it should be possible to "trigger" the different states of the @defer block https://angular.dev/guide/templates/defer#testing-defer-blocks ...but I wasn't able to get this example to work either. This was the only case where we directly test an inner component's reflected inputs, so IMO it makes sense to "let it go".
ybnd
force-pushed
the
defer-geospatial-map-components_9.x
branch
from
363d2bf to
c147354
Compare
tdonohue
added
the
port to main
tdonohue
moved this to 🙋 Needs Reviewers Assigned
in DSpace Maintenance (9.x, 8.x, 7.6.x)
tdonohue
removed
the
port to main
kshepherd
approved these changes
Jun 12, 2025
Member
kshepherd
left a comment
kshepherd
left a comment
There was a problem hiding this comment.
+1 tested and reviewed, important fix to lower resource overhead. this is a port of main which i've also approved
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace Maintenance (9.x, 8.x, 7.6.x)
tdonohue
added
the
1 APPROVAL
Member
|
merging immediately as the changes requested on the 9.x port are made here too |
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace Maintenance (9.x, 8.x, 7.6.x)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Add references/links to any related issues or PRs. These may include:
main.jsbundle caused by standalone component migration #2899Description
This PR moves some code & libraries required for geospatial maps out of the main bundle:
Maps are only show on a small number of pages. Making these components lazy saves us about 60 kB (gzipped).
This PR can also serve as a demo of the new @defer block introduced in Angular 17 -- we can likely leverage it for further improvements.
Instructions for Reviewers
Most importantly: maps should work as they did before.
I tested this on the
/browse/mappage, withgeospatialMapViewer.enableBrowseMap: truein the Angular configuration.Check Webpack bundle sizes before and after this PR:
npm run build:statswebpack-bundle-analyzer dist/browser/stats.jsonCode related to geospatial maps should now be outside of
+ 
main.js; you can highlight it with the following regex:(geospatial-map|leaflet|@terraformer)Before:
After:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.