Skip to content

change DELETE to OBSOLETE (DELETE)#4484

Open
GauravD2t wants to merge 1 commit intoDSpace:mainfrom
GauravD2t:Resource_Policy
Open

change DELETE to OBSOLETE (DELETE)#4484
GauravD2t wants to merge 1 commit intoDSpace:mainfrom
GauravD2t:Resource_Policy

Conversation

@GauravD2t
Copy link
Contributor

@GauravD2t GauravD2t commented Jun 17, 2025

References

Description

Change delete to OBSOLETE (DELETE) base on PR #10741
@tdonohue

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug authorization related to authorization, permissions or groups 1 APPROVAL pull request only requires a single approval to merge labels Jun 23, 2025
@tdonohue tdonohue added port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Jun 23, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jun 23, 2025
@GauravD2t
Copy link
Contributor Author

Hello @tdonohue
I hope you are doing well.
I have already submitted my code for this issue (see PR: #4484
), but it has not been reviewed yet. I just wanted to follow up and kindly request a review whenever you get some time.

Please let me know if any changes or additional information are required from my side.

Thank you for your time and consideration.

@tdonohue
Copy link
Member

@GauravD2t : This PR (along with the others you've alerted me to today) is currently in our "needs reviewers" column which means it's waiting on volunteer reviewers to help us to review/test it. Once a volunteer can give it a review/test and approves it, then we will work to get it merged. (I currently won't be able to get to this myself as I am reviewing higher priority PRs.) If you find this PR is waiting for a while, you are also welcome to partner with another developer and "trade" code reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge authorization related to authorization, permissions or groups bug port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Resource Policy - The DELETE resource policy is not working

2 participants