Skip to content

Russian translation#4487

Merged
tdonohue merged 3 commits intoDSpace:mainfrom
arvoConsultores:i18n-russian-translation
Jul 10, 2025
Merged

Russian translation#4487
tdonohue merged 3 commits intoDSpace:mainfrom
arvoConsultores:i18n-russian-translation

Conversation

@sergius02
Copy link
Contributor

References

Description

First version of a russian translatrion for DSpace

Instructions for Reviewers

Change the language using the dropdown

List of changes in this PR:

  • ru.json5. The main file of the translation.
  • config.example.yml. Added the option to the language list

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue requested a review from ybnd June 23, 2025 15:25
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Jun 23, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jun 23, 2025
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Jun 23, 2025
@tdonohue
Copy link
Member

@sergius02 : This PR is failing because the new ru.json5 file is failing lint checks. You should be able to see these failures locally by running npm run lint and then fixing the issues it has found. Once those lint checks pass, we can try to find a reviewer to test/review this.

@sergius02
Copy link
Contributor Author

@sergius02 : This PR is failing because the new ru.json5 file is failing lint checks. You should be able to see these failures locally by running npm run lint and then fixing the issues it has found. Once those lint checks pass, we can try to find a reviewer to test/review this.

Done

@tdonohue tdonohue added this to the 10.0 milestone Jul 10, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @sergius02 ! This looks good to me now. I did push up a very minor change to enable Russian by default in our default-app-config.ts (this ensures it appears in the dropdown by default). Beyond that, this all looks great.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Jul 10, 2025
@tdonohue tdonohue merged commit addd1b0 into DSpace:main Jul 10, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Jul 10, 2025
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-9_x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Russian translation

3 participants