You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First version of a russian translatrion for DSpace
Instructions for Reviewers
Change the language using the dropdown
List of changes in this PR:
ru.json5. The main file of the translation.
config.example.yml. Added the option to the language list
Checklist
My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
@sergius02 : This PR is failing because the new ru.json5 file is failing lint checks. You should be able to see these failures locally by running npm run lint and then fixing the issues it has found. Once those lint checks pass, we can try to find a reviewer to test/review this.
@sergius02 : This PR is failing because the new ru.json5 file is failing lint checks. You should be able to see these failures locally by running npm run lint and then fixing the issues it has found. Once those lint checks pass, we can try to find a reviewer to test/review this.
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @sergius02 ! This looks good to me now. I did push up a very minor change to enable Russian by default in our default-app-config.ts (this ensures it appears in the dropdown by default). Beyond that, this all looks great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 APPROVALpull request only requires a single approval to mergei18n / l10nInternationalisation and localisation, related to message catalogsport to dspace-9_xThis PR needs to be ported to `dspace-9_x` branch for next bug-fix release
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
First version of a russian translatrion for DSpace
Instructions for Reviewers
Change the language using the dropdown
List of changes in this PR:
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.