Update webpack and webpack-cli dependencies#4623
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Aug 5, 2025
Merged
Conversation
As far as I can tell dspace-angular doesn't explicitly need any particular version of webpack itself, but angular-cli specifies a semver string of `^5.54.0` so we should do the same. Also, our dependabot configuration currently considers minor and patch versions for updates, so we should not be using an exact version here anyway. See: https://github.com/angular/angular-cli/blob/18.2.x/packages/ngtools/webpack/package.json
Update webpack-cli from v5.1.4 to v6.0.1. This is compatible with webpack v5 and the minimum required Node.js version is 18.12.0. See: https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md
alanorth
added
dependencies
tdonohue
added
the
port to dspace-9_x
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 10.0 Release
Contributor
|
Successfully created backport PR for |
tdonohue
removed
the
port to dspace-9_x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As far as I can tell dspace-angular itself doesn't explicitly need any particular version of webpack itself, but angular-cli specifies a semver string of
^5.54.0so we should do the same.Also, our dependabot configuration currently considers minor and patch versions for updates, so we should not be using an exact version here anyway.
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
webpackfrom5.101.0to^5.54.0webpack-clifrom version 5 to version 6Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Test to see if the application builds and runs correctly. Look for errors in the terminal and browser console.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.