Skip to content

Fix dev mode#4810

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
4Science:task/main/DURACOM-417
Nov 12, 2025
Merged

Fix dev mode#4810
tdonohue merged 1 commit intoDSpace:mainfrom
4Science:task/main/DURACOM-417

Conversation

@AndreaBarbasso
Copy link
Contributor

References

Description

Introduced the tsconfig-paths package (github, npm) to resolve TypeScript path aliases.

Instructions for Reviewers

The tsconfig-paths package hooks into the Node.js module resolution system and allows it to understand the path mappings from the tsconfig.json file.
The fix involved updating all ts-node commands in the scripts section of package.json to include the -r tsconfig-paths/register flag. This flag pre-loads the path mappings, enabling Node.js to correctly resolve the aliased module paths at runtime and successfully execute the scripts.

To test this PR, check that the project can run both in dev and prod mode with no issues.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug high priority 1 APPROVAL pull request only requires a single approval to merge labels Nov 12, 2025
@tdonohue tdonohue moved this to 👀 Under Review in DSpace 10.0 Release Nov 12, 2025
@tdonohue tdonohue self-requested a review November 12, 2025 14:59
Copy link
Contributor

@nwoodward nwoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @AndreaBarbasso. This PR fixes the errors on those npm commands for me.

@github-project-automation github-project-automation bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 10.0 Release Nov 12, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @AndreaBarbasso ! I tested both prod mode and dev mode again. Both work well now, so this fixes the issues.

@tdonohue tdonohue added this to the 10.0 milestone Nov 12, 2025
@tdonohue tdonohue merged commit e308867 into DSpace:main Nov 12, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug high priority

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Dev mode not working

3 participants