feat(tinytag): replace svg to render #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyFBB
reviewed
Nov 11, 2024
LuckyFBB
reviewed
Nov 11, 2024
mortalYoung
requested changes
Nov 11, 2024
Collaborator
|
上面的 paddingWidth 设置为 9，下面的 text 元素设置的 x 又是 4 ，是不是有问题？ |
Collaborator
Author
text 在画布偏移 4的位置绘制， 那计算出来的 width 应该在该基础上 加 4 * 2 |
mortalYoung
requested changes
Nov 13, 2024
jin-sir
reviewed
Nov 14, 2024
src/tinyTag/index.tsx
Outdated
| <rect | ||
| x="0.5" | ||
| y="0.5" | ||
| width={width - 1} |
Collaborator
There was a problem hiding this comment.
这里加个判断吧？width初始值为0，在第一次渲染时，rect的width变成了 -1，会出现错误
Error: attribute width: A negative value is not valid. ("-1")
Collaborator
Author
There was a problem hiding this comment.
这个 会提取到 hook 里面， 处理掉
mortalYoung
approved these changes
Nov 19, 2024
jin-sir
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
变更类型
请选择以下选项以描述 PR 的类型：
相关问题
关联 issue： #466
变更内容
通过 svg 进行处理， 替换原本通过 css 进行缩放实现 10px 的效果
详细描述
技术方案
https://dtstack.yuque.com/rd-center/tqk74v/bddbmase2lcqpszb
对应 Previewer