Skip to content

Conversation

@mumiao
Copy link
Collaborator

@mumiao mumiao commented May 26, 2022

Description

support to set the expanded panels of Explorer

Fixes #726

Changes

Please describe the changes, help the reviewer to read your code.

  • support to set the expanded panels of Explorer
  • Collapse component support expand activeKeys
  • add Explorer setExpandedPanels testcase
  • add Collapse component activePanelKeys attribute testcase

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@mumiao mumiao requested review from Zaoei, mortalYoung and wewoor May 26, 2022 04:07
@mumiao mumiao self-assigned this May 26, 2022
@mumiao mumiao added the feature label May 26, 2022
@mumiao mumiao added this to the 0.9.0-beta.5 milestone May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #753 (6176975) into main (52d79b0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
+ Coverage   91.38%   91.41%   +0.03%     
==========================================
  Files         189      189              
  Lines        5952     5979      +27     
  Branches     1428     1440      +12     
==========================================
+ Hits         5439     5466      +27     
  Misses        506      506              
  Partials        7        7              
Impacted Files Coverage Δ
src/workbench/sidebar/explore/explore.tsx 80.00% <ø> (ø)
src/components/collapse/index.tsx 99.25% <100.00%> (+0.01%) ⬆️
src/model/workbench/explorer/explorer.tsx 100.00% <100.00%> (ø)
src/services/workbench/explorer/explorerService.ts 100.00% <100.00%> (ø)
...c/services/workbench/explorer/folderTreeService.ts 99.46% <0.00%> (+0.02%) ⬆️
src/services/workbench/editorService.ts 96.86% <0.00%> (+0.12%) ⬆️
src/controller/editor.tsx 48.34% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d79b0...6176975. Read the comment docs.

Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 753ba64 into main Jun 2, 2022
@wewoor wewoor deleted the feat/expandPanels branch June 2, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support to set the expanded panels of Explorer

4 participants