Skip to content

feat:Exposing more props to renderPane for EditorTab（invalid） #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Zaoei wants to merge 2 commits into from
Closed

feat:Exposing more props to renderPane for EditorTab（invalid） #757

Zaoei wants to merge 2 commits into from

Conversation

@Zaoei
Copy link
Collaborator

@Zaoei Zaoei commented Jun 1, 2022 •
edited
Loading

Description

exposing more props to renderPane for EditorTab

Fixes #649

Changes

  • tab.renderPane method arguments add tab and group
  • add renderPane example

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Zaoei Zaoei requested review from mortalYoung, mumiao and wewoor June 1, 2022 14:15
@Zaoei Zaoei self-assigned this Jun 1, 2022
@Zaoei Zaoei added this to the 0.9.0-beta.5 milestone Jun 1, 2022
@Zaoei Zaoei force-pushed the feat/extension_parameters branch from 1943679 to 57d56c7 Compare June 1, 2022 14:21
@mortalYoung
Copy link
Collaborator

mortalYoung commented Jun 2, 2022

为啥没有跑 codecov 呢 0.0

@mumiao mumiao added the feature label Jun 2, 2022
@mumiao
Copy link
Collaborator

mumiao commented Jun 2, 2022

#757

wewoor
wewoor approved these changes Jun 2, 2022
View reviewed changes
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

wewoor
wewoor approved these changes Jun 2, 2022
View reviewed changes
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mumiao
Copy link
Collaborator

mumiao commented Jun 2, 2022

+1

@Zaoei
Copy link
Collaborator Author

Zaoei commented Jun 2, 2022

@mortalYoung 我解决了冲突之后提交，就没有走 codecov。要不关闭这个 pr，我重新提一个？

@Zaoei
Copy link
Collaborator Author

Zaoei commented Jun 2, 2022

@mortalYoung @mumiao @wewoor
由于没有走 codecov，关闭这个 PR。
改用 #759

@Zaoei Zaoei changed the title feat:Exposing more props to renderPane for EditorTab feat:Exposing more props to renderPane for EditorTab（invalid） Jun 2, 2022
@wewoor wewoor closed this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wewoor wewoor wewoor approved these changes

@mortalYoung mortalYoung Awaiting requested review from mortalYoung

@mumiao mumiao Awaiting requested review from mumiao

Assignees

@Zaoei Zaoei

Labels

feature

Projects

None yet

Milestone

0.9.0-beta.5

Development

Successfully merging this pull request may close these issues.

feat:Exposing more props to renderPane for EditorTab

4 participants

@Zaoei @mortalYoung @mumiao @wewoor