Conversation
…get methods to extract session information
SmartDaqApplication needs to include the ConfigurationHelper header
Member
|
Setting to v5.5.0, at least for a determination of whether this is still relevant or the best way forward. |
…for nullptr in get_app_source_ids. Fix MLT source id config
mroda88
requested changes
Feb 18, 2026
Contributor
mroda88
left a comment
mroda88
left a comment
There was a problem hiding this comment.
This breaks the CTB logic as we need to request connections for the CTB app. We need to find the right solution.
Contributor
|
This will also fix #272 |
Mroda/config helper
…just the SmartDaqApplication source_id
update for CTB
mroda88
requested changes
Feb 27, 2026
Contributor
mroda88
left a comment
mroda88
left a comment
There was a problem hiding this comment.
Before we forget, the MLT needs to be updated to pick up both source ids of the CTB. I'm happy to take care of this next week. Sorry for the oversight.
Correct MLT logic for CTB
13 tasks
mroda88
approved these changes
Mar 11, 2026
Contributor
mroda88
left a comment
mroda88
left a comment
There was a problem hiding this comment.
This is now ok, and it has been tested at EHN1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a configuration helper class with methods to extract connection descriptors and source ids from other applications in the session while keeping the actual Session object private. The helper object is created by the
appfwk::ConfigurationManagerand passed to a smart applicationsgenerate_modules()method.Requires corresponding PR in
appfwk(DUNE-DAQ/appfwk#319)