Johnfreeman/daq cmake issue156 binding changes#23
Merged
jcfreeman2 merged 2 commits intodevelopfrom Sep 30, 2025
Merged
Conversation
added 2 commits
July 17, 2025 14:02
…ork done in daq-cmake to split OKS and non-OKS Python bindings solibs
…ake_issue156_binding_changes
andrewmogan
approved these changes
Sep 30, 2025
Contributor
andrewmogan
left a comment
andrewmogan
left a comment
There was a problem hiding this comment.
Test build, integration tests, and checks all pass. We've also confirmed with Marco that updating import confmodel -> import confmodel_dal in ehn1-daqconfigs is not a big deal. Approved.
jcfreeman2
deleted the
johnfreeman/daq-cmake_issue156_binding_changes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DUNE-DAQ/daq-deliverables#192
This code was successfully built (https://github.com/DUNE-DAQ/daq-release/actions/runs/18112261637) and tested (https://github.com/DUNE-DAQ/daq-release/actions/runs/18113789848) as part of
PYLIBFD_DEV_250929_A9