Open
Conversation
0bba273 to
c60efe9
Compare
e6a71ee to
0dbf745
Compare
959d438 to
8586192
Compare
Collaborator
Author
|
Hi @PawelPlesniak @henry-wallace-phys, this monster of a PR is ready for review. Might be easier to review if you just read the docs to be honest, which is found here: https://dune-daq.github.io/daqpytools/ @henry-wallace-phys since youre not too familiar with the logging framework, can you give comments on how clear and easy to follow the docs are? hopefully the tutorial and the how tos and the best practices should help you get up and running with your runconfui refactor :) @PawelPlesniak since youre an expert, can you flick through everything? (sorry..) Let me know if im missing something svp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
vibes
Fix #52
Fix #43
Add docs and deploy them. Its a lot.
There are two kinds of docs that exist, one for the user and one for the developer. The user docs are found in docs/ and the dev docs are in docs_dev/. The split is so that the user docs are used to make the dune daq readthedocs website, while the dev docs are primarily found in the mkdocs (similar to how it is in drunc).
Speaking of mkdocs, they should be found here: https://dune-daq.github.io/daqpytools/
It contains both the user and developer docs just so we have everything in one consistent place.
The docs themselves follow the diataxis framework, such that each page should be only one of the four: tutorial, guide, reference, explanation. That should make the reading and understanding of the docs much clearer. \
The api references are automatically generated, this is done using the dev_docs/generate_logging_autodocs.py script.
The other script in that file just cleans up the file structure in the two docs so they are clearly displayed in the mkdocs.
For this one feature to work, we have an empty folder called docs_anchor, which is eventually used to build the autodocs so that we have the user and dev docs in the same heirarchy.
Type of change
Testing checklist
View https://dune-daq.github.io/daqpytools/ and read through everything :')
dbt-build --unittest)pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))