Skip to content

Make the TRBModule callback-based#423

Merged
eflumerf merged 5 commits intodevelopfrom
eflumerf/CallbackTRB-Full
Jul 29, 2025
Merged

Make the TRBModule callback-based#423
eflumerf merged 5 commits intodevelopfrom
eflumerf/CallbackTRB-Full

Conversation

@eflumerf
Copy link
Copy Markdown
Member

No description provided.

@eflumerf eflumerf self-assigned this Jun 24, 2025
@eflumerf eflumerf added enhancement New feature or request deliverable subtask A change that delivers part or all of the functionality for a daq-deliverable Issue labels Jun 24, 2025
@eflumerf eflumerf marked this pull request as draft June 24, 2025 20:29
@eflumerf eflumerf marked this pull request as ready for review July 24, 2025 14:37
Copy link
Copy Markdown
Contributor

@mroda88 mroda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was tested at EHN1, adding stress tests too. Dashboard of the test is http://np04-srv-017:31023/d/v5_4_0-overview/daq-overview?orgId=1&var-influxdb=f68a27a2-f292-478c-8093-2a4adad3be1b&var-postgresql=c7e9e333-25c9-49e7-b209-b9492f70d419&var-session=mrigan-np02-mrigan-stress-test&var-controller=root-controller&from=1753783207554&to=1753791042586 The first run was with cubic congestion algorithm (which is not the desired one) and the second run was with congestion algorithm set to BBR.

The performance of the new TRB is the same as the old one with the BBR congestion algorithm, and even better with the cubic algorithm. So this is desirable for v5.4.0 as discusse in the SWIT meeting today.

@eflumerf eflumerf merged commit addc1d2 into develop Jul 29, 2025
1 check passed
@eflumerf eflumerf deleted the eflumerf/CallbackTRB-Full branch July 29, 2025 15:49
@eflumerf eflumerf mentioned this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deliverable subtask A change that delivers part or all of the functionality for a daq-deliverable Issue enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants