Change stop timeout to milliseconds in DFOModule#464
Merged
wesketchum merged 1 commit intoprep-release/fddaq-v5.5.0from Dec 9, 2025
Merged
Change stop timeout to milliseconds in DFOModule#464wesketchum merged 1 commit intoprep-release/fddaq-v5.5.0from
wesketchum merged 1 commit intoprep-release/fddaq-v5.5.0from
Conversation
eflumerf
approved these changes
Dec 9, 2025
bieryAtFnal
approved these changes
Dec 9, 2025
Collaborator
bieryAtFnal
left a comment
There was a problem hiding this comment.
Looks good to me. I verified that existing regression tests in daqsystemtest continue to run normally, and I verified that when disk writing is artificially slowed down, the full DFO timeout time is 100 ms, as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following up on the reported error messages in the DFO on trigger decisions not finishing, @bieryAtFnal noted that this stop has a configuration that says it should be in ms, but then is converted to microseconds in the module --> there's a very short timeout there for the DFO, which doesn't give much time for trigger record builders to return.
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)(still haven't run tests ... wanted to get the PR started first ...)
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))