Skip to content

Change stop timeout to milliseconds in DFOModule#464

Merged
wesketchum merged 1 commit intoprep-release/fddaq-v5.5.0from
wketchum_DFOStopTimeoutInMS
Dec 9, 2025
Merged

Change stop timeout to milliseconds in DFOModule#464
wesketchum merged 1 commit intoprep-release/fddaq-v5.5.0from
wketchum_DFOStopTimeoutInMS

Conversation

@wesketchum
Copy link
Contributor

Description

Following up on the reported error messages in the DFO on trigger decisions not finishing, @bieryAtFnal noted that this stop has a configuration that says it should be in ms, but then is converted to microseconds in the module --> there's a very short timeout there for the DFO, which doesn't give much time for trigger record builders to return.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

(still haven't run tests ... wanted to get the PR started first ...)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

Copy link
Collaborator

@bieryAtFnal bieryAtFnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I verified that existing regression tests in daqsystemtest continue to run normally, and I verified that when disk writing is artificially slowed down, the full DFO timeout time is 100 ms, as expected.

@wesketchum wesketchum merged commit d57d3fa into prep-release/fddaq-v5.5.0 Dec 9, 2025
4 checks passed
@wesketchum wesketchum deleted the wketchum_DFOStopTimeoutInMS branch December 9, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants