Conversation
creating TimeSync messages.
bieryAtFnal
approved these changes
Jan 15, 2026
Collaborator
bieryAtFnal
left a comment
bieryAtFnal
left a comment
There was a problem hiding this comment.
These changes look good to me. However, the fake_data_producer_test in daqsystemtest needed to be changed as a result. That change is in DUNE-DAQ/daqsystemtest#288.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when creating TimeSync messages.
Description
Resolves Issue #391 by having FakeDataProdModule use TimestampEstimatorSystem to produce timestamps using the DUNE-DAQ clock (getting the clock frequency from the Session's DetectorConfig object). These timestamps are used to create TimeSync messages only; the module uses trigger timestamps for any produced data Fragments.
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)I believe the only possible change is in
fake_data_producers_test.py, which passed in my testing.